GNOME Bugzilla – Bug 769844
gnome-games: Fix compile time errors
Last modified: 2016-08-14 13:24:27 UTC
Games has several compile time warnings, we should fix at least the ones not related to deprecated API as it should be easy to fix. Here are the warnings: ui/display-box.vala:102.33-102.76: warning: Gdk.Cursor.new has been deprecated since 3.16 ui/application-window.vala:272.4-272.31: warning: unhandled error `GLib.Error' display_box.runner.resume (); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ui/application.vala:190.2-190.18: warning: Games.Application.quit hides inherited method `GLib.Application.quit'. Use the `new' keyword if hiding was intentional private void quit () { ^^^^^^^^^^^^^^^^^ grilo/grilo-cover.vala:51.13-51.26: warning: unhandled error `GLib.Error' var uid = uid.get_uid (); ^^^^^^^^^^^^^^ grilo/grilo-cover.vala:73.4-73.59: warning: unhandled error `GLib.FileError' FileUtils.set_data (cover_path, mess.response_body.data); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ retro/retro-runner.vala:192.21-192.39: warning: Retro.search_module has been deprecated since 0.8. Use Retro.ModuleQuery.lookup_module_for_basename utils/directory.vala:19.2-19.32: warning: method `Games.Directory.try_next_file' never used private FileInfo? try_next_file (FileEnumerator enumerator) { ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ tracker/mime-type-tracker-query.vala:14.23-14.34: warning: copying delegates is not supported desktop-tracker-query.vala:34.3-34.17: warning: unhandled error `GLib.Error' check_uri (uri); ^^^^^^^^^^^^^^^ desktop-tracker-query.vala:46.8-46.43: warning: unhandled error `GLib.ShellError' if (!Shell.parse_argv (command, out args)) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ desktop-tracker-query.vala:47.4-47.80: warning: unhandled error `Games.CommandError' throw new CommandError.INVALID_COMMAND (_("Invalid command '%s'."), command); ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Created attachment 333230 [details] [review] ui: Rename quit() into quit_application() in Application This avoids overriding the quit() method implicitely, which produced a compile time warning.
Created attachment 333231 [details] [review] grilo: Improve errors handling in GriloCover This fixes several compile time warnings.
Created attachment 333232 [details] [review] utils: Remove the unused Directory.try_next_file() This fixes a compile time warning.
Created attachment 333233 [details] [review] ui: Handle errors from Runner.resume() This avoids a compile time warning.
Created attachment 333234 [details] [review] tracker: Make MimeTypeTrackerQuery own its callback This avoids a compile time warning.
Created attachment 333235 [details] [review] desktop: Handle errors from DesktopTrackerQuery.process_cursor() This allows to avoid some compile time warnings.
Attachment 333230 [details] pushed as 2d8f28a - ui: Rename quit() into quit_application() in Application Attachment 333231 [details] pushed as a38035b - grilo: Improve errors handling in GriloCover Attachment 333232 [details] pushed as b53dc5e - utils: Remove the unused Directory.try_next_file() Attachment 333233 [details] pushed as ac53b25 - ui: Handle errors from Runner.resume() Attachment 333234 [details] pushed as b438109 - tracker: Make MimeTypeTrackerQuery own its callback Attachment 333235 [details] pushed as 97bd9c6 - desktop: Handle errors from DesktopTrackerQuery.process_cursor()