After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769836 - gamepads: Support gamepads properly mapped in the kernel
gamepads: Support gamepads properly mapped in the kernel
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: GNOME Games maintainers
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-13 13:29 UTC by Adrien Plazas
Modified: 2016-08-16 15:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gamepad: Support gamepads without a mapping (5.09 KB, patch)
2016-08-13 13:33 UTC, Adrien Plazas 		committed Details | Review

Description Adrien Plazas 2016-08-13 13:29:57 UTC 
We should support gamepads which are properly mapped in the kernel (exposing A, B, X, Y... buttons) even if we don't have a mapping for them.
Comment 1 Adrien Plazas 2016-08-13 13:33:11 UTC 
Created attachment 333218 [details] [review]
gamepad: Support gamepads without a mapping

Support gamepads sending proper gamepad events (buttons A, B, X, Y...)
even if they don't have a mapping.
Comment 2 Bastien Nocera 2016-08-14 15:59:00 UTC 
Review of attachment 333218 [details] [review]:

Looks good apart from this.

::: src/gamepad/raw-gamepad.vala
@@ +9,3 @@
  */
 private interface Games.RawGamepad : Object {
+	public abstract signal void standard_button_event (StandardGamepadButton button, bool value);

I don't understand why you need a different signal for this. Why not reuse the definitions from the Linux kernel? This code will only work on Linux anyway...
Comment 3 Adrien Plazas 2016-08-16 15:40:41 UTC 
Attachment 333218 [details] pushed as 3279866 - gamepad: Support gamepads without a mapping