After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769801 - Tell the user nicely when a ROM isn't supported
Tell the user nicely when a ROM isn't supported
Status: RESOLVED FIXED
Product: gnome-games
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Adrien Plazas
GNOME Games maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-12 14:18 UTC by Mathieu Bridon
Modified: 2016-08-17 06:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ui: Add ErrorDisplay (5.46 KB, patch)
2016-08-17 06:23 UTC, Adrien Plazas 		committed Details | Review
ui: Display runner errors with an ErrorDisplay (5.34 KB, patch)
2016-08-17 06:23 UTC, Adrien Plazas 		committed Details | Review
ui: Remove unused display_error() from CollectionBox (1.20 KB, patch)
2016-08-17 06:23 UTC, Adrien Plazas 		committed Details | Review
ui: Remove unused info_box from CollectionBox (1.69 KB, patch)
2016-08-17 06:23 UTC, Adrien Plazas 		committed Details | Review
ui: Remove unused overlay from CollectionBox (1.29 KB, patch)
2016-08-17 06:23 UTC, Adrien Plazas 		committed Details | Review

Description Mathieu Bridon 2016-08-12 14:18:13 UTC 
When I click on an NDS ROM without the appropriate libretro core, I get an in-app notification telling me:

    Couldn't run game: module 'libretro-nintendo-ds.so' not found

That's not very useful for a user, as it exposes them to technical jargon.

Maybe we could do something nicer, a bit like Books does it for unsupported formats?
Comment 1 Adrien Plazas 2016-08-17 06:23:02 UTC 
Created attachment 333445 [details] [review]
ui: Add ErrorDisplay

This will be used in the next commit to display the errors related to
running a game in a nicer way.
Comment 2 Adrien Plazas 2016-08-17 06:23:08 UTC 
Created attachment 333446 [details] [review]
ui: Display runner errors with an ErrorDisplay

When an error occurs when running a game, displays the error in a
RunError widget rather than an info box.

This displays errors in a much nicer way.
Comment 3 Adrien Plazas 2016-08-17 06:23:14 UTC 
Created attachment 333447 [details] [review]
ui: Remove unused display_error() from CollectionBox
Comment 4 Adrien Plazas 2016-08-17 06:23:20 UTC 
Created attachment 333448 [details] [review]
ui: Remove unused info_box from CollectionBox
Comment 5 Adrien Plazas 2016-08-17 06:23:25 UTC 
Created attachment 333449 [details] [review]
ui: Remove unused overlay from CollectionBox
Comment 6 Adrien Plazas 2016-08-17 06:27:57 UTC 
Attachment 333445 [details] pushed as 7627afe - ui: Add ErrorDisplay
Attachment 333446 [details] pushed as 97113a6 - ui: Display runner errors with an ErrorDisplay
Attachment 333447 [details] pushed as d3c5c38 - ui: Remove unused display_error() from CollectionBox
Attachment 333448 [details] pushed as 4e22b2c - ui: Remove unused info_box from CollectionBox
Attachment 333449 [details] pushed as 0284820 - ui: Remove unused overlay from CollectionBox