After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769769 - rtpmanager: Reduce the number of upstream GstRTPRetransmissionRequest events.
rtpmanager: Reduce the number of upstream GstRTPRetransmissionRequest events.
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-08-11 22:04 UTC by GstBlub
Modified: 2018-11-03 15:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
rtpmanager: Reduce the number of upstream GstRTPRetransmissionRequest events. (6.17 KB, patch)
2016-08-11 22:04 UTC, GstBlub 		needs-work Details | Review

Description GstBlub 2016-08-11 22:04:06 UTC 
Created attachment 333145 [details] [review]
rtpmanager: Reduce the number of upstream GstRTPRetransmissionRequest events.

Rather than sending one GstRTPRetransmissionRequest upstream event for each sequence number from a RR, send one per FCI entry.  Should reduce upstream events significantly in high packet loss situations.
Comment 1 Håvard Graff (hgr) 2016-08-30 21:16:46 UTC 
Review of attachment 333145 [details] [review]:

For the rtxsend part, it would be very easy to add a test for that new functionality here: https://github.com/GStreamer/gst-plugins-good/blob/master/tests/check/elements/rtprtx.c. It would both serve as documentation of what you are doing, as well as proving to yourself and everyone else that this works as expected. Also, I am curious if you have encountered any implementation that actually uses the BLP field from https://tools.ietf.org/html/rfc4585#section-6.2.1 ?
Comment 2 GstBlub 2016-09-02 17:33:26 UTC 
The only implementation I have played with so far is gstreamer itself, which uses the BLP field.
Comment 3 Olivier Crête 2016-09-15 19:12:09 UTC 
Review of attachment 333145 [details] [review]:

As Håvard said, it would be really great if there was a unit test, otherwise it will break, it's just a matter of time.
Comment 4 GStreamer system administrator 2018-11-03 15:10:43 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/289.