After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769731 - Should use EGL_NO_CONTEXT when creating EGL_WAYLAND_BUFFER_WL images
Should use EGL_NO_CONTEXT when creating EGL_WAYLAND_BUFFER_WL images
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: wayland
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-11 08:31 UTC by Sjoerd Simons
Modified: 2016-08-29 14:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.34 KB, patch)
2016-08-11 08:31 UTC, Sjoerd Simons 		committed Details | Review

Description Sjoerd Simons 2016-08-11 08:31:06 UTC 
Created attachment 333097 [details] [review]
proposed patch

The WL_bind_wayland_display spec says EGL images should be created using EGL_WAYLAND_BUFFER_WL as  the target and EGL_NO_CONTEXT as the contents. Mesa is lenient and accepts any context, other stacks not so much.

Same issue as #765351 for cogl
Comment 1 Daniel Stone 2016-08-26 15:35:16 UTC 
LGTM; would be good to push since this does terminally break other stacks, and given that it's required for strict conformance, Mesa will probably get changed to enforce it at some stage ...
Comment 2 Rui Matos 2016-08-29 14:41:49 UTC 
Thanks for the patch and review