After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769711 - networkmanager-1.2.4: please make building/installation of examples optional
networkmanager-1.2.4: please make building/installation of examples optional
Status: RESOLVED FIXED
Product: NetworkManager
Classification: Platform
Component: general
1.2.x
Other Linux
: Normal normal
: ---
Assigned To: NetworkManager maintainer(s)
NetworkManager maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-08-10 18:54 UTC by Pacho Ramos
Modified: 2017-02-09 17:36 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Pacho Ramos 2016-08-10 18:54:20 UTC
Currently we are needing to apply some "sedding" downstream to not always build and install the examples. I have seen multiple different projects that have a "--with-examples" configure switch to allow us to enable/disable this... could this be included please

Thanks a lot
Comment 1 Beniamino Galvani 2016-08-10 19:55:12 UTC
(In reply to Pacho Ramos from comment #0)
> Currently we are needing to apply some "sedding" downstream to not always
> build and install the examples. I have seen multiple different projects that
> have a "--with-examples" configure switch to allow us to enable/disable
> this... could this be included please

Can you please explain if you have a specific reason to disable examples? They are only few C files whose compilation time is negligible and no file gets installed AFAICS.
Comment 2 Pacho Ramos 2016-08-11 18:11:40 UTC
Well, historically we are dropping its building because they are not really needed and also were a bit prone to fail to build (like https://bugs.gentoo.org/show_bug.cgi?id=588828 ... and probably older bugs we are not remembering now as we are trying to disable them for a long long time).

Also, even if the compilation time is small... why is it useful to build them if later won't be installed and (in our case) the build directory won't be available as soon as package is installed? :/

Thanks :)
Comment 3 Thomas Haller 2016-08-12 13:16:35 UTC
If there are build failures for the examples (like the mentioned gentoo bug), then those failures should be fixed, instead disabling the build.

-- obviously, if some examples have dependencies which are not available, then  ./configure should be smart enough to disable the build of those examples conditionally. E.g. always building the QT examples, unless QT/moc is not available.


I wouldn't reject a patch to disable them altogether. But I'd really like to see patches from gentoo to fix build failures instead.
Comment 4 Thomas Haller 2017-02-09 17:36:51 UTC
the QT examples are never build if configure detects that QT is not available.


unless building with --enable-tests, the tests/examples are not build during a regular build anymore.
In this case, you still can run `make check`, which only then builds the tests and examples.

if you don't want to build the tests, configure without --enable-tests (and don't run `make check`).