GNOME Bugzilla – Bug 769554
[Mir] Touchpad scrolling not as smooth as it should be
Last modified: 2016-09-28 15:19:17 UTC
Created attachment 332799 [details] [review] Do not filter out small touchpad scroll motions When scrolling with a touchpad the left-right direction seems to be wrong, and it seems to be less smooth than with X11 or qt-mir clients. This is probably because mir provides scroll motion in rotary ticks - which are usually been translated as 15-times larger than touchpad motion units. The attached patch resolves the problem.
Review of attachment 332799 [details] [review]: Looks OK, can we leave the -delta_y alone though? ::: gdk/mir/gdkmireventsource.c @@ +198,3 @@ event->scroll.direction = GDK_SCROLL_SMOOTH; + event->scroll.delta_x = delta_x; + event->scroll.delta_y = delta_y; Yes, for me this fixes the horizontal smooth scrolling, but breaks the vertical smooth scrolling. I guess there's some disparity between the vertical scroll direction in Mir and GTK+? Can we undo the second change here?
(In reply to William Hua from comment #1) > Review of attachment 332799 [details] [review] [review]: > > Looks OK, can we leave the -delta_y alone though? > > ::: gdk/mir/gdkmireventsource.c > @@ +198,3 @@ > event->scroll.direction = GDK_SCROLL_SMOOTH; > + event->scroll.delta_x = delta_x; > + event->scroll.delta_y = delta_y; > > Yes, for me this fixes the horizontal smooth scrolling, but breaks the > vertical smooth scrolling. I guess there's some disparity between the > vertical scroll direction in Mir and GTK+? Can we undo the second change > here? I do not know what direction is positive or negative. A user can customize that via server side options. We can keep it -delta_y. I just hope this will be in the end common across toolktis.
Created attachment 333250 [details] [review] [PATCH] Do not filter out small scroll event fractions