GNOME Bugzilla – Bug 769553
dashdemux: Fix sidx snap/keyframe seeks
Last modified: 2016-08-11 10:24:41 UTC
See https://bugzilla.gnome.org/show_bug.cgi?id=741104#c60 Problem is that sidx based segments might not be given in the manifest, so seeking on the mpd parser would always give us 0 as the actual position... Which for snap seeks would be the new segment start. As explained in the comment linked above, the fix is what was reverted in got. It however breaks the unit tests as explained there, which are IMHO just broken by design. As such I propose to disable these tests until they're fixed or removed. It might make more sense to use validate tests on real streams instead.
commit f126403bd61a27224cfd4d0dafde32daea9fc0c9 Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu Aug 11 12:19:59 2016 +0200 dashdemux: Disable unit test for the time being It uses random data streams but dashdemux nowadays actually looks into the streams and doesn't like randomness very much. The tests should probably just become validate tests on real streams. https://bugzilla.gnome.org/show_bug.cgi?id=769553 commit 02f688ee9d5ca96639e96cf24371769214e162e0 Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu Aug 11 12:11:22 2016 +0200 Revert "Revert "dashdemux: When doing SIDX seeking, return instead of overriding the timestamp with 0 from the MPD seeking method"" This reverts commit aea2c13fc1672a7260679d706d0a084a34ba7531.