After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769373 - thegamesdb: Use the Game Boy Color MIME type
thegamesdb: Use the Game Boy Color MIME type
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
unspecified
Other Linux
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2016-08-01 08:54 UTC by Adrien Plazas
Modified: 2016-08-25 13:22 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
thegamesdb: Use Game Boy Color registered MIME type (1.83 KB, patch)
2016-08-01 08:57 UTC, Adrien Plazas
committed Details | Review

Description Adrien Plazas 2016-08-01 08:54:05 UTC
This depends on https://bugs.freedesktop.org/show_bug.cgi?id=97161

We should use the 'application/x-gameboy-color-rom' MIME type to discriminate Game Boy Color games from Game Boy ones rather than trying to disambiguate them from 'application/x-gameboy-rom'.
Comment 1 Adrien Plazas 2016-08-01 08:57:19 UTC
Created attachment 332466 [details] [review]
thegamesdb: Use Game Boy Color registered MIME type

Use the 'application/x-gameboy-color-rom' MIME type rather than trying
to disambiguate it from 'application/x-gameboy-rom'.
Comment 2 Bastien Nocera 2016-08-02 11:22:37 UTC
Review of attachment 332466 [details] [review]:

Looks good to commit after the shared-mime-info patch has been committed.
Comment 3 Adrien Plazas 2016-08-25 07:17:09 UTC
Which is now done. :)
Comment 4 Adrien Plazas 2016-08-25 13:22:15 UTC
Attachment 332466 [details] pushed as 7cf0751 - thegamesdb: Use Game Boy Color registered MIME type