After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769215 - aacparse: Need to relax the detection of ADTS
aacparse: Need to relax the detection of ADTS
Status: RESOLVED DUPLICATE of bug 721697
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Mac OS
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-27 08:45 UTC by Gabby Park
Modified: 2016-07-27 08:58 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Gabby Park 2016-07-27 08:45:23 UTC 
The relax logic was reverted in 2ad1f20e7b430985091ea2f4e8ba753f9e908c46.
But, according to ISO/IEC 13818-7, "channel_config" field in adts_fixed_header() may have value of 0.
In case of stream contained channel_config == 0, aacparse would not deliever audio frame to downstream element.

We need to remove commit 2ad1f20e7b430985091ea2f4e8ba753f9e908c46.
Comment 1 Sebastian Dröge (slomo) 2016-07-27 08:51:16 UTC 
This is the history of it:

commit 2ad1f20e7b430985091ea2f4e8ba753f9e908c46
Author: Vincent Penquerc'h <vincent.penquerch@collabora.co.uk>
Date:   Tue Jan 14 09:43:33 2014 +0000

    Revert "aacparse: relax the detection of ADTS"
    
    This was pushed by mistake along with the V4L2 fix.
    
    This reverts commit 8eb4b032bef444397c4d211f2095c173ba114187.

commit 8eb4b032bef444397c4d211f2095c173ba114187
Author: Akihiro Tsukada <atsukada@users.sourceforge.net>
Date:   Wed Feb 27 01:45:52 2013 +0900

    aacparse: relax the detection of ADTS
    
    According to ISO/IEC 13818-7, "channel_config" field in ADTS header
    may have value of 0, as in the case of frame with PCE.
    gst_aac_parse_detect_streams() returned FALSE for those frames
    and discarded them.


Vincent, why did you revert it again and where does the original patch come from?
Comment 2 Vincent Penquerc'h 2016-07-27 08:55:00 UTC 
I reverted it because I had applied it on the wrong branch for testing, so it got pushed along with another patch I intended to push.

The patch is from https://bugzilla.gnome.org/show_bug.cgi?id=721697
Comment 3 Sebastian Dröge (slomo) 2016-07-27 08:58:58 UTC 
Thanks for taking the time to report this.
This particular bug has already been reported into our bug tracking system, but please feel free to report any further bugs you find.

*** This bug has been marked as a duplicate of bug 721697 ***