The "Reconnect" item in the sidebar's network context menu should work. I'm not sure the feature is common enough to justify a more prominent option in the UI ...

How do you get the network to appear in the sidebar in the first place?

It should show up right after it has been created - isn't that the case? That would certainly be a bug we want fixed ...

Ok, I see now that if I click the "+", then the button to add a network, then Cancel, the network appears in the sidebar. That wasn't really intuitive as the whole process doesn't feel like completing an action (since you cancel half way through) but would be enough to cover the need described here.

Now I added Freenode this way, and tried the reconnect action from the context menu, but nothing happens. For networks with at least one channel, the reconnect action makes a throbber appear next to their name — not the case for this network with no channel.

(In reply to Alexandre Franke from comment #4)
> Ok, I see now that if I click the "+", then the button to add a network,
> then Cancel, the network appears in the sidebar. That wasn't really
> intuitive as the whole process doesn't feel like completing an action (since
> you cancel half way through) but would be enough to cover the need described
> here.

True, but then creating a network where you don't want to join any channels isn't very intuitive either (I figure that your use case is likely an externally managed channel list on a bouncer, but that's very much limited to hardcode IRC users, i.e. not at all common)


> Now I added Freenode this way, and tried the reconnect action from the
> context menu, but nothing happens.

Bummer, this is apparently expected:
https://telepathy.freedesktop.org/spec-0.20/Account.html#org.freedesktop.Telepathy.Account.Reconnect

I'll attach a patch to address this.

Created attachment 332169 [details] [review]
roomList: Add "Connect" menu item

The existing reconnect action only works for accounts that are not
offline (by user request). However there are cases where initiating
a connection can be useful, mostly when not joining channels through
the UI, but via an external service like webirc or bouncers. To
account for this, show a "Connect" item when the "Reconnect" action
isn't available.

(In reply to Florian Müllner from comment #5)
> True, but then creating a network where you don't want to join any channels
> isn't very intuitive either (I figure that your use case is likely an
> externally managed channel list on a bouncer, but that's very much limited
> to hardcode IRC users, i.e. not at all common)

Sure, I acknowledge that and this is why I'm not really going to complain about that if there's a way, even a non obvious one.


> I'll attach a patch to address this.

Do you need me to test it? If so, can you maybe provide a flatpak?

(In reply to Alexandre Franke from comment #7)
> > I'll attach a patch to address this.
> 
> Do you need me to test it? If so, can you maybe provide a flatpak?

I did test the patch before attaching it, so just getting it reviewed should be enough. Still, getting more testing cannot hurt, so I pushed a flatpak to https://people.gnome.org/~fmuellner/flatpak/repo/ (signed with https://keybase.io/fmuellner/key.asc) ...

Thanks.

I tried it both with the "GNOME" and "Freenode" networks that are in the list by default and I get a connection failure.

Not good, but unlikely to be related to the patch. Can you run with POLARI_DEBUG=1?

Would that be `POLARI_DEBUG=1 flatpak run org.gnome.Polari`?

Yeah. I'm not sure though whether flatpak filters the environment, so maybe it won't work after all ...

I don't see any output in the console. :-/

Review of attachment 332169 [details] [review]:

looks good to me.

Comment on attachment 332169 [details] [review]
roomList: Add "Connect" menu item

Attachment 332169 [details] pushed as c9706cd - roomList: Add "Connect" menu item

(In reply to Alexandre Franke from comment #9)
> I tried it both with the "GNOME" and "Freenode" networks that are in the
> list by default and I get a connection failure.

A bit of a shot in the dark, but can you try again with an updated flatpak?
(We've had a bit of bad luck in that the server that ends up being picked by default for "GNOME" has been very on-and-off in the past, and falling back to alternative servers is buggy on startup - the patches in bug 766935 should address that, and I've included them in the updated build now)

I tried again with Freenode and GNOME, still get a failure. It takes about 1 second to fail, I get a throbber before that.

Bummer. I'm afraid I'm out of ideas then - for what it's worth, I did try to run with POLARI_DEBUG=1 (as in comment #11), and the env variable is passed through just fine, so no idea why you aren't seeing any output
(I'd expect at least a couple of annoying GTK+ warnings with the unstable platform)

Oh I may have mislead you. I do see the GTK+ warnings, but I see them without the environment variable as well. When I said no output, I meant nothing more than without the variable. No connection error or anything like that.

I got thinking "does it happen with my bouncer too?" and so I tried it. It turns out it does work in this case. Weird, isn't it?

Yeah ...

GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org.
As part of that, we are mass-closing older open tickets in bugzilla.gnome.org
which have not seen updates for a longer time (resources are unfortunately
quite limited so not every ticket can get handled).

If you can still reproduce the situation described in this ticket in a recent
and supported software version of Polari, then please follow
  https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines
and create a new ticket at
  https://gitlab.gnome.org/GNOME/polari/-/issues/

Thank you for your understanding and your help.