GNOME Bugzilla – Bug 769080
decodebin3: fix collection refcounting
Last modified: 2016-07-25 07:05:58 UTC
.
Created attachment 331987 [details] [review] decodebin3: fix collection refcounting My collection leak fix 83f30627cd9460157935e7e9603c60a15555967e introduced a crash in this scenario: audiotestsrc ! decodebin3 ! fakesink The reference handling of collection in decodebin3 wasn't very clear and my attempt to fix the leak introduced a regression where we went one reference short in some other scenarios. Fixing this by: - Giving a strong reference to DecodebinInput making things clearer - Fixing get_merged_collection() which was sometimes returning an existing reference and sometimes a new one.
Created attachment 331988 [details] [review] playbin3: fix collection leak The collection referenced owned by playbin3 was not released when it was destroyed.
commit c1f37edfd9e5939de78aa442afd5dec03e966193 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri Jul 22 14:40:25 2016 +0200 playbin3: fix collection leak The collection referenced owned by playbin3 was not released when it was destroyed. https://bugzilla.gnome.org/show_bug.cgi?id=769080 commit 2c0a4d20d4c75bf2cfdc03d18321241221421561 Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk> Date: Fri Jul 22 14:35:17 2016 +0200 decodebin3: fix collection refcounting My collection leak fix 83f30627cd9460157935e7e9603c60a15555967e introduced a crash in this scenario: audiotestsrc ! decodebin3 ! fakesink The reference handling of collection in decodebin3 wasn't very clear and my attempt to fix the leak introduced a regression where we went one reference short in some other scenarios. Fixing this by: - Giving a strong reference to DecodebinInput making things clearer - Fixing get_merged_collection() which was sometimes returning an existing reference and sometimes a new one. https://bugzilla.gnome.org/show_bug.cgi?id=769080