After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769054 - Trivial cleanups
Trivial cleanups
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-21 19:46 UTC by Thomas Andersen
Modified: 2016-07-22 02:47 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Indentatuion fixes (1.19 KB, patch)
2016-07-21 19:47 UTC, Thomas Andersen 		committed Details | Review
Simplify assert (939 bytes, patch)
2016-07-21 19:47 UTC, Thomas Andersen 		committed Details | Review
Don't assign var to itself (1.04 KB, patch)
2016-07-21 19:48 UTC, Thomas Andersen 		committed Details | Review

Description Thomas Andersen 2016-07-21 19:46:36 UTC 
Hi,

My first patch to mutter. I saw the recent activity and wanted to see if I could help out.

These patches are all just trivial code cleanups.
Comment 1 Thomas Andersen 2016-07-21 19:47:14 UTC 
Created attachment 331914 [details] [review]
Indentatuion fixes
Comment 2 Thomas Andersen 2016-07-21 19:47:36 UTC 
Created attachment 331915 [details] [review]
Simplify assert
Comment 3 Thomas Andersen 2016-07-21 19:48:04 UTC 
Created attachment 331916 [details] [review]
Don't assign var to itself
Comment 4 Florian Müllner 2016-07-21 20:20:32 UTC 
Review of attachment 331914 [details] [review]:

OK
Comment 5 Florian Müllner 2016-07-21 20:20:37 UTC 
Review of attachment 331915 [details] [review]:

OK
Comment 6 Florian Müllner 2016-07-21 20:20:41 UTC 
Review of attachment 331916 [details] [review]:

Yes.
Comment 7 Thomas Andersen 2016-07-21 20:35:37 UTC 
It seems my commit access was removed due to inactivity. Can I ask you to push it for me?
Comment 8 Jonas Ådahl 2016-07-22 02:47:13 UTC 
(In reply to Thomas Andersen from comment #7)
> It seems my commit access was removed due to inactivity. Can I ask you to
> push it for me?

I'll push it for you.