After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 769024 - mutter-3.21.4 fails to compile without wayland
mutter-3.21.4 fails to compile without wayland
Status: RESOLVED FIXED
Product: mutter
Classification: Core
Component: general
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: mutter-maint
mutter-maint
Depends on:
Blocks:
 
 
Reported: 2016-07-21 08:58 UTC by john.frankish@outlook.com
Modified: 2016-07-21 12:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
main: Fix compilation with wayland disabled (781 bytes, patch)
2016-07-21 10:26 UTC, Jonas Ådahl
committed Details | Review

Description john.frankish@outlook.com 2016-07-21 08:58:23 UTC
compiling mutter-3.21.4 with:

$ ./configure --prefix=/usr/local --disable-static --localstatedir=/var --libexecdir=/usr/local/lib/mutter --enable-compile-warnings=no --disable-wayland --with-x --disable-wayland-egl-server

$ make
...
  CC       core/keybindings.lo
  CC       core/main.lo
core/main.c: In function 'meta_init':
core/main.c:444:26: error: 'META_COMPOSITOR_TYPE_WAYLAND' undeclared (first use in this function)
   if (compositor_type == META_COMPOSITOR_TYPE_WAYLAND)
                          ^
core/main.c:444:26: note: each undeclared identifier is reported only once for each function it appears in
Makefile:1929: recipe for target 'core/main.lo' failed
make[4]: *** [core/main.lo] Error 1
make[4]: Leaving directory '/usr/src/mutter-3.21.4/src'
Makefile:2105: recipe for target 'all-recursive' failed
make[3]: *** [all-recursive] Error 1
make[3]: Leaving directory '/usr/src/mutter-3.21.4/src'
Makefile:1183: recipe for target 'all' failed
make[2]: *** [all] Error 2
make[2]: Leaving directory '/usr/src/mutter-3.21.4/src'
Makefile:474: recipe for target 'all-recursive' failed
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory '/usr/src/mutter-3.21.4'
Makefile:404: recipe for target 'all' failed
make: *** [all] Error 2
Comment 1 Jonas Ådahl 2016-07-21 10:26:41 UTC
Created attachment 331866 [details] [review]
main: Fix compilation with wayland disabled
Comment 2 Florian Müllner 2016-07-21 10:52:11 UTC
Review of attachment 331866 [details] [review]:

Not tested, but code looks obviously correct.
Comment 3 john.frankish@outlook.com 2016-07-21 11:24:52 UTC
mutter-3.21.4 compiles OK now - thanks.

BTW 767528 is still open
Comment 4 Jonas Ådahl 2016-07-21 12:35:39 UTC
Attachment 331866 [details] pushed as ad7ec6b - main: Fix compilation with wayland disabled