After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768916 - pathbar: fix underallocations reported in GTK+ 3.21
pathbar: fix underallocations reported in GTK+ 3.21
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-18 09:08 UTC by Ernestas Kulik
Modified: 2016-07-18 10:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
pathbar: fix underallocations (6.75 KB, patch)
2016-07-18 09:08 UTC, Ernestas Kulik
committed Details | Review

Description Ernestas Kulik 2016-07-18 09:08:42 UTC
Starting with GTK+ 3.21, Nautilus is constantly reporting
underallocations happening in the path bar. That is chiefly caused by
some assumptions made in the code (i.e. both slider buttons are of the
same width, which is untrue, due to the “linked” style class).

This commit corrects those assumptions by using widths of both slider
buttons in allocation calculations.
Comment 1 Ernestas Kulik 2016-07-18 09:08:47 UTC
Created attachment 331680 [details] [review]
pathbar: fix underallocations
Comment 2 Carlos Soriano 2016-07-18 10:12:25 UTC
Review of attachment 331680 [details] [review]:

Go ahead, thanks!!
Comment 3 Ernestas Kulik 2016-07-18 10:18:38 UTC
Attachment 331680 [details] pushed as d2f98e2 - pathbar: fix underallocations