After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768827 - encoder: h264: Too many references given in pic_params for P-frames.
encoder: h264: Too many references given in pic_params for P-frames.
Status: RESOLVED INVALID
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
git master
Other All
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-14 23:16 UTC by Scott D Phillips
Modified: 2016-07-22 09:26 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
[PATCH] encoder: h264: Set pic_param ReferenceFrames from slice reflists (4.31 KB, patch)
2016-07-14 23:18 UTC, Scott D Phillips 		rejected Details | Review

Description Scott D Phillips 2016-07-14 23:16:41 UTC 
The pic_param's ReferenceFrames is populated with the whole reference pool for a picture which may have references that are not included in the actual slice's reference list (P-slices for instance). It sort of looks like the driver might then do motion estimation in this situation with the invalid provided reference picture, but I'm not able to craft a video where that happens so maybe not.
Comment 1 Scott D Phillips 2016-07-14 23:18:30 UTC 
Created attachment 331554 [details] [review]
[PATCH] encoder: h264: Set pic_param ReferenceFrames from slice reflists
Comment 2 sreerenj 2016-07-15 14:02:11 UTC 
Review of attachment 331554 [details] [review]:

No, this is wrong.
VAEncPictureParameterBufferH264->ReferenceFrames should contain all frames existing in dpb.

I still suspect driver is giving unnecessary warning here, thinking pic_param->ref pic order should be align with slice_header.
Comment 3 sreerenj 2016-07-21 08:47:01 UTC 
Removing the unnecessary warning in driver:
https://lists.freedesktop.org/archives/libva/2016-July/004184.html
Comment 4 sreerenj 2016-07-22 09:26:59 UTC 
Pushed the diver patch, Closing this bug as invalid.