After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768731 - Prefix signal ID enum entries with SIGNAL_ to avoid using EOF
Prefix signal ID enum entries with SIGNAL_ to avoid using EOF
Status: RESOLVED FIXED
Product: libsoup
Classification: Core
Component: Misc
unspecified
Other All
: Normal normal
: ---
Assigned To: libsoup-maint@gnome.bugs
libsoup-maint@gnome.bugs
: 769313 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-07-12 13:15 UTC by Philip Withnall
Modified: 2016-07-29 19:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Prefix signal ID enum entries with SIGNAL_ to avoid using EOF (3.71 KB, patch)
2016-07-12 13:15 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2016-07-12 13:15:28 UTC 
Trivial patch attached. Fixes compilation under JHBuild on Fedora 23 for me.
Comment 1 Philip Withnall 2016-07-12 13:15:31 UTC 
Created attachment 331326 [details] [review]
Prefix signal ID enum entries with SIGNAL_ to avoid using EOF

glibc defines EOF as a macro, so we cannot use that as the name for a
signal ID enum entry, otherwise it will be preprocessed to some number
if we end up with the wrong header included, and compilation will fail.
Instead, prefix signal ID enum entries with ‘SIGNAL_’ in
SoupCacheClientInputStream and SoupClientInputStream.
Comment 2 Dan Winship 2016-07-12 14:36:08 UTC 
Comment on attachment 331326 [details] [review]
Prefix signal ID enum entries with SIGNAL_ to avoid using EOF

sure
Comment 3 Philip Withnall 2016-07-12 15:45:45 UTC 
Thanks for the fast review.

Attachment 331326 [details] pushed as 72c5759 - Prefix signal ID enum entries with SIGNAL_ to avoid using EOF
Comment 4 Dan Winship 2016-07-29 19:09:18 UTC 
*** Bug 769313 has been marked as a duplicate of this bug. ***