Created attachment 331256 [details] [review]
info: factor out os info retrieval function

This code will be reused in the future to retrieve
information stored in /etc/os-release file and, as
preparation for the next patch that retrieves and
displays the build-id of the OS.
.

Created attachment 331258 [details] [review]
info: show build-id

While developing, it's useful to show the build
id of the installed OS whenever available, which
the info panel doesn't handle for now.

This patch adds the ability to display the build
id of the installed OS when available.

Review of attachment 331256 [details] [review]:

::: panels/info/cc-info-panel.c
@@ +395,2 @@
 static char *
+get_os_info (const gchar* field)

That means re-reading the file for every field, probably not the best.

I would have something like:
GHashTable *parse_os_release(void);
which returns a hashtable of key/values.

Open it once, stuff all the key values, and keep it around until you've used all the fields you needed.

Review of attachment 331258 [details] [review]:

That looks fine, but will need changes for the API proposed in the other patch.

Created attachment 331334 [details] [review]
info: factor out os info retrieval function

Done.

Created attachment 331335 [details] [review]
info: show build-id

Done.

Review of attachment 331334 [details] [review]:

OK.

Just this:
> This patch also changes the function signature to return a hash
> table instead of simply reading the field,

This information is already in the patch itself. Remove it.

Review of attachment 331335 [details] [review]:

> installed OS whenever available, which the info panel doesn't

when available.

> This patch adds the ability to display the build id of the
> installed OS when available.

You already said that in the commit subject, and in the first paragraph.

Looks fine otherwise.

Thanks for the reviews.

Attachment 331334 [details] pushed as 8b70c44 - info: factor out os info retrieval function
Attachment 331335 [details] pushed as 6052e46 - info: show build-id