After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768585 - Generate VAPI just on C libraries and using GObject
Generate VAPI just on C libraries and using GObject
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: templates
3.21.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-08 16:14 UTC by Daniel Espinosa
Modified: 2016-07-11 22:36 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Turning off by default VAPIGEN (1.48 KB, patch)
2016-07-08 16:43 UTC, Daniel Espinosa 		none Details | Review
VAPIGEN enable just for C languages (1.24 KB, patch)
2016-07-11 19:39 UTC, Daniel Espinosa 		accepted-commit_now Details | Review

Description Daniel Espinosa 2016-07-08 16:14:07 UTC 
We need to declare if a C library project will have GObject classes, if so then VAPI generation for Vala bindings is Ok, but if not, should be disable by default.

In order to accomplish this we need to add options on "ide" command line tool, to create GObject based libraries and enable VAPI generation.

While Vala projects do not require VAPIGEN, then this is not useful for them.

Because the last, I will push a commit to turning it off by default, unless ied tool is fixed.
Comment 1 Daniel Espinosa 2016-07-08 16:43:55 UTC 
Created attachment 331101 [details] [review]
Turning off by default VAPIGEN

It is ready to push in my local 3.20 branch.
Comment 2 Christian Hergert 2016-07-08 20:47:34 UTC 
Supporting non-GObject based C libraries isn't really in scope for these templates. Our long term goal is to teach people how to write good GObject based C libraries.

I'd be amenable to setting this False when Vala though.
Comment 3 Daniel Espinosa 2016-07-11 19:39:41 UTC 
Created attachment 331262 [details] [review]
VAPIGEN enable just for C languages

When project is C this patch enable VAPIGEN.

I can't find a way to know if I'm a library template to check against, because VAPIGEN is useful just for libraries.
Comment 4 Christian Hergert 2016-07-11 20:37:20 UTC 
Review of attachment 331262 [details] [review]:

cool