After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768580 - style-schemes: Use the style scheme for the search shadow color
style-schemes: Use the style scheme for the search shadow color
Status: RESOLVED FIXED
Product: gnome-builder
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: GNOME Builder Maintainers
GNOME Builder Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-07-08 15:17 UTC by Matthew Leeds
Modified: 2016-07-08 20:42 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
style-schemes: Use the style scheme for the search shadow color (6.27 KB, patch)
2016-07-08 15:17 UTC, Matthew Leeds 		accepted-commit_now Details | Review

Description Matthew Leeds 2016-07-08 15:17:47 UTC 
This is not an important bugfix but it's nice to get rid of TODOs in
the codebase.
Comment 1 Matthew Leeds 2016-07-08 15:17:49 UTC 
Created attachment 331090 [details] [review]
style-schemes: Use the style scheme for the search shadow color

The search shadow color is the color of everything in the buffer other
than search results. The setting for it is not currently turned on in
Builder so you have to set IdeSourceView's show-search-shadow property
to TRUE to see it. This commit moves the color of the shadow to the
style scheme so it is more easily configurable. It also renames the
variable used for the search-match style object to make the code more
readable.
Comment 2 Christian Hergert 2016-07-08 20:21:05 UTC 
Review of attachment 331090 [details] [review]:

LGTM
Comment 3 Matthew Leeds 2016-07-08 20:42:38 UTC 
Pushed as commit 46f767d97700e3c7d6b5e9522b647c83878612c5