GNOME Bugzilla – Bug 768509
matroskamux: Segmentation fault in string comparison
Last modified: 2016-07-25 10:26:58 UTC
Created attachment 330988 [details] [review] matroskamux: Fix segmentation fault Hi, Following this patch [1], I have changed the following string comparisons because the error hasn't dissapeared but it has been moved later. Best regards. David. [1]https://cgit.freedesktop.org/gstreamer/gst-plugins-good/commit/?id=ac3b1cf2ed9fa89a1814dcde133bbd73d597bac7
Review of attachment 330988 [details] [review]: ::: gst/matroska/matroska-mux.c @@ +3569,3 @@ + if (!g_strcmp0 (collect_pad->track->codec_id, + GST_MATROSKA_CODEC_ID_AUDIO_OPUS) Question is why this is NULL in the first place, and why we didn't error out earlier because of that already. We probably should :) Same goes for the other commit you mentioned.
Good question, but I don't know about the muxer code. Probably there is an error in another part of the code and we need to fix the origin, but in the meanwhile we need a solution because this error is breaking the execution.
It seems like hiding only a more severe bug though, let's fix it properly instead.
How can you reproduce the crash btw?
I agree with you. I'm sorry, but I don't have way to reproduce the error, it appears once in a while.
commit dbb8ec4639f225c57384a876749c27a59f21baf1 Author: Sebastian Dröge <sebastian@centricular.com> Date: Thu Jul 7 18:23:07 2016 +0300 matroskamux: Error out if we start writing data with some pads not having a codec id yet This can only happen if a) upstream somehow gets around the CAPS event failing or b) there never being any CAPS event. The following code assumes that all pads have a codec-id. https://bugzilla.gnome.org/show_bug.cgi?id=768509
Hi Sebastian, Thanks for your fix. Regards.