After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768165 - Can't add a note to a contact
Can't add a note to a contact
Status: RESOLVED FIXED
Product: gnome-contacts
Classification: Core
Component: general
3.20.x
Other Linux
: Normal normal
: ---
Assigned To: GNOME Contacts maintainer(s)
GNOME Contacts maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2016-06-29 05:29 UTC by romain
Modified: 2017-08-12 11:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
row (985 bytes, patch)
2017-07-26 23:28 UTC, Thiago 		committed Details | Review

Description romain 2016-06-29 05:29:33 UTC 
Hello,

When I create a contact and I populates the field "note"; after saving, the
note was not added to the contact.
This issue only affects gnome-contact (evolution does not have this problem).

Cordialy.
Comment 1 Thiago 2017-07-26 23:28:23 UTC 
Created attachment 356447 [details] [review]
row

I'm not familiar with GTK but following the code it seems like we were passing the wrong Widget to the function to seatch for. We were using the text_value which is inside of a ScrolledWindow so the fucntion wasn't able to return the right row number.
Comment 2 Niels De Graef 2017-08-12 11:22:55 UTC 
Hey Thiago, thanks for the patch! Great catch btw :-)

FWIW, there's a WIP branch 'wip/nielsdg/contact-editor-rewrite' which should also solve some other problems (such as some WARNINGs)

Landed as commit dcd922d86e6ce13a0fa6546cee732fd40f4531ce .