After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768146 - d3dvideosink: leak on caps string
d3dvideosink: leak on caps string
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
1.8.2
Other Windows
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-28 16:03 UTC by Jonathan Roy
Modified: 2016-07-04 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
d3dvideosink-leak-on-caps-string.patch (782 bytes, patch)
2016-06-28 16:03 UTC, Jonathan Roy 		needs-work Details | Review
revised patch (909 bytes, patch)
2016-06-28 16:23 UTC, Jonathan Roy 		committed Details | Review

Description Jonathan Roy 2016-06-28 16:03:18 UTC 
Created attachment 330490 [details] [review]
d3dvideosink-leak-on-caps-string.patch

Plugged simple leak on caps string.
Comment 1 Sebastian Dröge (slomo) 2016-06-28 16:06:28 UTC 
Review of attachment 330490 [details] [review]:

Good find, can you update your patch? :)

::: sys/d3dvideosink/d3dvideosink.c
@@ -285,3 @@
   GST_DEBUG_OBJECT (bsink, " ");
 
   GST_DEBUG_OBJECT (bsink, "Caps: %s", (tmp = gst_caps_to_string (caps)));

This should just use GST_PTR_FORMAT, e.g.

GST_DEBUG_OBJECT (bsink, "Caps: %" GST_PTR_FORMAT, caps)
Comment 2 Jonathan Roy 2016-06-28 16:12:10 UTC 
Do you mean to remove line 285?
Comment 3 Jonathan Roy 2016-06-28 16:23:48 UTC 
Created attachment 330497 [details] [review]
revised patch
Comment 4 Sebastian Dröge (slomo) 2016-06-28 16:27:21 UTC 
commit dea792292e17ddf655dc41366a712d748a7ae4b6
Author: Sebastian Dröge <sebastian@centricular.com>
Date:   Tue Jun 28 19:26:29 2016 +0300

    d3dvideosink: Replace some more gst_caps_to_string() with GST_PTR_FORMAT
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768146

commit 93191c92f1894b1bead6e8815dc928cf8282786c
Author: Jonathan Roy <jroy@adetelgroup.com>
Date:   Tue Jun 28 11:50:59 2016 -0400

    d3dvideosink: leak on caps string
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768146