After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768143 - libxml-2.0 bindings for htmlEncodeEntities and UTF8ToHtml use out instead of ref
libxml-2.0 bindings for htmlEncodeEntities and UTF8ToHtml use out instead of ref
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.32.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-28 15:04 UTC by Guillaume Poirier-Morency
Modified: 2016-07-21 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that fix the described issue (1.80 KB, patch)
2016-06-28 15:04 UTC, Guillaume Poirier-Morency 		committed Details | Review

Description Guillaume Poirier-Morency 2016-06-28 15:04:37 UTC 
Created attachment 330488 [details] [review]
Patch that fix the described issue

According to the documentation:

> The value of @inlen after return is the number of octets consumed as the return value is positive, else unpredictable. The value of @outlen after return is the number of octets consumed.

The proposed patch simply replace 'out' by 'ref'.

Considering that it's not even working at the moment, I would not consider this as a breaking change.
Comment 1 Al Thomas 2016-06-28 15:08:56 UTC 
Review of attachment 330488 [details] [review]:

Patch looks good to me.

The VAPI now matches the documented API for these two functions:
http://xmlsoft.org/html/libxml-HTMLparser.html#htmlEncodeEntities
http://xmlsoft.org/html/libxml-HTMLparser.html#UTF8ToHtml