After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 768141 - bus: chain up constructed.
bus: chain up constructed.
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-28 13:58 UTC by Guillaume Desmottes
Modified: 2016-07-04 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
bus: chain up 'constructed' (766 bytes, patch)
2016-06-28 13:58 UTC, Guillaume Desmottes 		none Details | Review
bus: chain up 'constructed' (764 bytes, patch)
2016-06-28 14:10 UTC, Guillaume Desmottes 		committed Details | Review

Description Guillaume Desmottes 2016-06-28 13:58:20 UTC 
.
Comment 1 Guillaume Desmottes 2016-06-28 13:58:36 UTC 
Created attachment 330485 [details] [review]
bus: chain up 'constructed'

Needed so GstBus can be tracked by the leaks tracer.
Comment 2 Sebastian Dröge (slomo) 2016-06-28 14:06:13 UTC 
Review of attachment 330485 [details] [review]:

::: gst/gstbus.c
@@ +151,3 @@
   }
+
+  ((GObjectClass *) gst_bus_parent_class)->constructed (object);

G_OBJECT_CLASS (gst_bus_parent_class)->...

For consistency with everywhere else we do that
Comment 3 Guillaume Desmottes 2016-06-28 14:10:24 UTC 
Created attachment 330486 [details] [review]
bus: chain up 'constructed'

Needed so GstBus can be tracked by the leaks tracer.
Comment 4 Sebastian Dröge (slomo) 2016-06-28 14:23:36 UTC 
commit e11539c30b51a9872c16765b01ab81dfe264505f
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Tue Jun 28 15:01:17 2016 +0200

    bus: chain up GObject::constructed() to the parent class' implementation
    
    Needed so GstBus can be tracked by the leaks tracer.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=768141