GNOME Bugzilla – Bug 768036
Warning on startup when dbus-update-activation-environment is unavailable
Last modified: 2016-09-02 02:51:18 UTC
Created attachment 330366 [details] [review] gnome-session: avoid warning in startup script Debian has dbus-update-activation-environment in a dbus-user-session subpackage. In case it is uninstalled, an ugly warning gets printed when starting gnome-session: $ gnome-session /usr/bin/gnome-session: 15: /usr/bin/gnome-session: dbus-update-activation-environment: not found Avoid it.
dbus-update-activation-environment is part of the dbus package in debian. I don't think that anything in GNOME whould work without dbus (tell me if I'm wrong), so it should be present already.
(In reply to Laurent Bigonville from comment #1) > dbus-update-activation-environment is part of the dbus package in debian. Um, yeah, I guess I must have just assumed this was not the case without checking...? So ignore this bug.
(In reply to Michael Catanzaro from comment #2) > Um, yeah, I guess I must have just assumed this was not the case without > checking...? So ignore this bug. Yeah, my downstream environment's dbus package is based on an older version of Debian, and I just assumed the absence of the binary meant it was in the other package, and tricked myself into thinking I had checked that when I did not. So we'll just carry this downstream until we get newer dbus.
Comment on attachment 330366 [details] [review] gnome-session: avoid warning in startup script (note: the change is harmless, but the commit message is wrong)
I'd like to pick this up again - the patch seems trivial enough and imho only the commit message would need to be corrected. dbus-update-activation-environment was introduced with dbus 1.10.4 - so silencing this warning only means that we correctly do not require such a high dbus version gnome-session by itself does not depend on any specific version of dbus at all - but on dbus-glib-1 (DBUS_GLIB_REQUIRED=0.76) the latest version of dbus-glib (ver 106) still only requires dbus-1 1.8 - it is thus a valid setup
Review of attachment 330366 [details] [review]: It might be better to add 2>&1 after which call, or we see another warning: which: no dbus-update-activation-environment in (/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin)
Created attachment 333404 [details] [review] A little modification based on Michael's patch.
Review of attachment 333404 [details] [review]: ::: gnome-session/gnome-session.in @@ +16,1 @@ i don't think we need the which call. just: dbus-update-activation-environment --all >& /dev/null ||: should be enough
Created attachment 333421 [details] [review] Patch based on Ray's comment
Review of attachment 333421 [details] [review]: .
Comment on attachment 333421 [details] [review] Patch based on Ray's comment pushed as 4abdb7