After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767954 - Fix screen shield arrow shadows
Fix screen shield arrow shadows
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2016-06-22 19:18 UTC by Rui Matos
Modified: 2016-06-23 17:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
StShadowHelper: properly use the actor's box to paint the shadow (1.24 KB, patch)
2016-06-22 19:18 UTC, Rui Matos 		committed Details | Review
ScreenShield: fix setting each arrow's opacity on _animateArrows() (993 bytes, patch)
2016-06-22 19:18 UTC, Rui Matos 		committed Details | Review
Arrow: compute a paint volume that accounts for the shadow (1.29 KB, patch)
2016-06-22 19:18 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-06-22 19:18:19 UTC 
It turns out that we weren't painting the shadow properly, see the
patches.
Comment 1 Rui Matos 2016-06-22 19:18:26 UTC 
Created attachment 330208 [details] [review]
StShadowHelper: properly use the actor's box to paint the shadow

We're using an unitialized box resulting in an undefined shadow box
size.

_st_paint_shadow_with_opacity() already computes the shadow's bounding
box from the source actor's box so we just need to pass that along.
Comment 2 Rui Matos 2016-06-22 19:18:32 UTC 
Created attachment 330209 [details] [review]
ScreenShield: fix setting each arrow's opacity on _animateArrows()
Comment 3 Rui Matos 2016-06-22 19:18:37 UTC 
Created attachment 330210 [details] [review]
Arrow: compute a paint volume that accounts for the shadow

Otherwise the shadow gets clipped to the actor's allocation.
Comment 4 Florian Müllner 2016-06-22 19:25:29 UTC 
Review of attachment 330209 [details] [review]:

Yikes
Comment 5 Florian Müllner 2016-06-22 19:25:34 UTC 
Review of attachment 330208 [details] [review]:

Ugh, that dates back to d6fe008b2c334f8f7 - how did that go unnoticed for so long?
Comment 6 Florian Müllner 2016-06-22 19:25:38 UTC 
Review of attachment 330210 [details] [review]:

OK
Comment 7 Rui Matos 2016-06-23 17:03:58 UTC 
Attachment 330208 [details] pushed as 3e93a1b - StShadowHelper: properly use the actor's box to paint the shadow
Attachment 330209 [details] pushed as e02467e - ScreenShield: fix setting each arrow's opacity on _animateArrows()
Attachment 330210 [details] pushed as 408211b - Arrow: compute a paint volume that accounts for the shadow