After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767938 - Add support for AVStereo3D API for stereoscopic video
Add support for AVStereo3D API for stereoscopic video
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other Linux
: Normal enhancement
: 1.11.90
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-22 08:53 UTC by Sebastian Dröge (slomo)
Modified: 2017-03-16 10:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
avviddec: Map any stereo3D info to multiview modes (2.63 KB, patch)
2016-07-08 18:38 UTC, Jan Schmidt
needs-work Details | Review
avvidenc: Add Stereo3D mapping (2.51 KB, patch)
2016-07-09 14:31 UTC, Jan Schmidt
accepted-commit_now Details | Review
avviddec: Map any stereo3D info to multiview modes (6.12 KB, patch)
2017-03-16 04:23 UTC, Jan Schmidt
committed Details | Review
avvidenc: Add Stereo3D mapping (2.51 KB, patch)
2017-03-16 04:23 UTC, Jan Schmidt
committed Details | Review

Description Sebastian Dröge (slomo) 2016-06-22 08:53:30 UTC
See libavutil/stereo3d.h
Comment 1 Jan Schmidt 2016-07-08 18:38:28 UTC
Created attachment 331107 [details] [review]
avviddec: Map any stereo3D info to multiview modes

Map any libav Stereo3D side data to GStreamer multiview
mode / flags for playback.
Comment 2 Jan Schmidt 2016-07-08 18:38:58 UTC
Here's the decoder part (tested only with H.264)
Comment 3 Jan Schmidt 2016-07-09 14:31:52 UTC
Created attachment 331128 [details] [review]
avvidenc: Add Stereo3D mapping

Add mapping between GStreamer multiview modes/flags and
libav Stereo3D frame packings when encoding video.
Comment 4 Sebastian Dröge (slomo) 2016-07-11 06:53:00 UTC
Comment on attachment 331107 [details] [review]
avviddec: Map any stereo3D info to multiview modes

Shouldn't this come with code that checks if the multiview mode/flags have changed (per frame) and renegotiate then? Like we do for interlaced for example
Comment 5 Jan Schmidt 2016-07-11 07:03:38 UTC
(In reply to Sebastian Dröge (slomo) from comment #4)
> Comment on attachment 331107 [details] [review] [review]
> avviddec: Map any stereo3D info to multiview modes
> 
> Shouldn't this come with code that checks if the multiview mode/flags have
> changed (per frame) and renegotiate then? Like we do for interlaced for
> example

Good point.

In case it's not clear, there's also a patch to write for the demuxers and muxers to map AVPacket side-data to GStreamer caps too.
Comment 6 Sebastian Dröge (slomo) 2016-10-20 09:53:26 UTC
What's the status here?
Comment 7 Jan Schmidt 2016-10-20 12:52:00 UTC
I didn't get back to working on the patches yet, so no change - the viddec patch needs updating for renegotiation, and we need some patches for the demuxers/muxers case.
Comment 8 Jan Schmidt 2017-03-16 04:23:33 UTC
Created attachment 348059 [details] [review]
avviddec: Map any stereo3D info to multiview modes

Map any libav Stereo3D side data to GStreamer multiview
mode / flags for playback.
Comment 9 Jan Schmidt 2017-03-16 04:23:40 UTC
Created attachment 348060 [details] [review]
avvidenc: Add Stereo3D mapping

Add mapping between GStreamer multiview modes/flags and
libav Stereo3D frame packings when encoding video.
Comment 10 Jan Schmidt 2017-03-16 04:27:42 UTC
I'm not sure it's worth writing the code mapping input/output to/from demuxers/muxers - we don't map or encourage the use of any of the libav muxers that support signalling of multiview information anyway (mp4, mkv, asf)