After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767680 - rtph265pay: fix nal type parsing an sps/pps/vps insertion via config-interval property
rtph265pay: fix nal type parsing an sps/pps/vps insertion via config-interval...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-15 07:39 UTC by Jürgen Slowack
Modified: 2016-06-27 06:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch for rtph265pay to fix a bug in parsing nal unit type. (834 bytes, patch)
2016-06-15 07:39 UTC, Jürgen Slowack 		committed Details | Review

Description Jürgen Slowack 2016-06-15 07:39:40 UTC 
Created attachment 329843 [details] [review]
Patch for rtph265pay to fix a bug in parsing nal unit type.

The nal unit type is incorrectly parsed in rtph265pay. As a result, VPS, SPS, and PPS are not detected and will not be periodically inserted when setting "config-interval" to a non-default value (e.g., 1). As a result, starting the sender before the receiver does not work. This is fixed with this very simple patch.

Example sender pipeline:

gst-launch-1.0 videotestsrc ! queue ! x265enc tune=zerolatency speed-preset=ultrafast ! queue ! rtph265pay config-interval=-1 ! udpsink

Example receiver pipeline:

gst-launch-1.0 udpsrc ! application/x-rtp, payload=96 ! queue ! rtph265depay ! h265parse ! queue ! avdec_h265 ! queue ! videoconvert ! xvimagesink
Comment 1 Tim-Philipp Müller 2016-06-15 12:20:16 UTC 
Seems to match the spec. Thanks!

commit 98b62e397b3a27d7ddc0d50d5f8ac4d4f3af54a0
Author: Jürgen Slowack <jurgen.slowack@barco.com>
Date:   Wed Jun 15 11:19:43 2016 +0200

    rtph265: fix NAL unit type parsing and SPS/PPS/VPS detection
    
    Fixes sps/pps/vps insertion via the config-interval property.
    
    https://bugzilla.gnome.org//show_bug.cgi?id=767680