After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767585 - Middle-clicking the title bar doesn't send Epiphany to the background
Middle-clicking the title bar doesn't send Epiphany to the background
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
3.20.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: Epiphany Maintainers
Epiphany Maintainers
: 767728 (view as bug list)
Depends on: 739634
Blocks:
 
 
Reported: 2016-06-13 06:46 UTC by Marius Gedminas
Modified: 2016-06-16 14:24 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Revert "title-box: Do not propagate button press events in title mode" (1.19 KB, patch)
2016-06-14 14:50 UTC, Michael Catanzaro
committed Details | Review

Description Marius Gedminas 2016-06-13 06:46:36 UTC
Steps to reproduce

1. Middle-click the titlebar of an Epiphany window

Expected behaviour:

- Epiphany window is sent to the background

Actual behaviour:

- Nothing happens.
Comment 1 Michael Catanzaro 2016-06-13 15:37:46 UTC
I'm confused, why would you expect this behavior? I tested several apps and middle clicking the title bar doesn't do anything for any of them. What desktop environment are you using -- does your window manager implement this behavior? What happens if you middle click the title bar in another app that uses GtkHeaderBar (e.g. nautilus)?
Comment 2 Marius Gedminas 2016-06-13 16:09:59 UTC
I'm using GNOME 3.20 (with gnome-shell).

The action of middle-clicking can be customized with GNOME Tweak Tool, which changes the org.gnome.desktop.wm.preferences action-middle-click-titlebar setting.  dconf-editor tells me "lower" is the default value for this setting!

Nautilus and gnome-terminal both lower the window when I middle-click their headerbars.  AFAIU this is implemented in the standard GtkHeaderBar widget.

Experimenting a little bit more I see that if I click near the edges of Epiphany's headerbar, I get the expected lowering action, but if I click on the text in the middle, or in the margins around it (which are part of the EphyTitleBox, according to GTK Inspector), then nothing happens.
Comment 3 Michael Catanzaro 2016-06-13 17:19:49 UTC
OK, I wonder if I broke it in bug #744307. If you happen to be a developer, you could check by reverting that patch. Otherwise... we want to remove that title box anyway, so this will get fixed when that happens.
Comment 4 Marius Gedminas 2016-06-14 11:31:31 UTC
Yes, reverting commit 25df8678f43c26f990b07a758516585a91811df6 makes this bug go away.
Comment 5 Michael Catanzaro 2016-06-14 14:47:45 UTC
Well since it didn't fix anything, let's do that.
Comment 6 Michael Catanzaro 2016-06-14 14:50:12 UTC
The following fix has been pushed:
e94904e Revert "title-box: Do not propagate button press events in title mode"
Comment 7 Michael Catanzaro 2016-06-14 14:50:15 UTC
Created attachment 329801 [details] [review]
Revert "title-box: Do not propagate button press events in title mode"

This reverts commit 25df8678f43c26f990b07a758516585a91811df6.
Comment 8 Michael Catanzaro 2016-06-14 14:51:29 UTC
Fix will be in next week's 3.20.3 release. Thanks for reporting.
Comment 9 Michael Catanzaro 2016-06-16 14:24:33 UTC
*** Bug 767728 has been marked as a duplicate of this bug. ***