After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767573 - Main window: don't shrink main_view to a width of zero
Main window: don't shrink main_view to a width of zero
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
3.20.x
Other All
: Normal enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
: 771059 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2016-06-12 18:26 UTC by Christian Stadelmann
Modified: 2016-09-12 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
A simple 3-line patch by setting "shrink" child property to False (833 bytes, patch)
2016-06-12 18:26 UTC, Christian Stadelmann 		none Details | Review
Same patch as before, but redone (946 bytes, patch)
2016-06-12 22:02 UTC, Christian Stadelmann 		none Details | Review
patch v3 (1.03 KB, patch)
2016-08-29 12:26 UTC, Christian Stadelmann 		accepted-commit_now Details | Review

Description Christian Stadelmann 2016-06-12 18:26:27 UTC 
Created attachment 329644 [details] [review]
A simple 3-line patch by setting "shrink" child property to False

Problem: in nautilus' main window, the right side container (GtkOverlay: main_view) can be resized to have a width of 0. This might render nautilus unusable for some users.

Steps to reproduce:
1. open nautilus, have a sidebar shown
2. resize sidebar to fill whole window width

What happens:
main window content (everything in main_view) is hidden.

What should happen:
main_view should never be hidden.

Affected version:
nautilus-3.20.1-1.fc24.x86_64
gtk3-3.20.6-1.fc24.x86_64
glib2-2.48.1-1.fc24.x86_64
Comment 1 Ernestas Kulik 2016-06-12 19:04:07 UTC 
Hi, Christian, nice catch!

For patches you should follow the workflow here: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Submitting_patches
Your patch is not in the format that is easy to apply.

Setting the main_view child property “shrink” to “false” causes the sidebar to shrink along with the window, which can get very annoying. It also has the side effect of limiting the minimum size of the window.

That’s just my $0.02. Waiting for someone from higher up to provide input.
Comment 2 Christian Stadelmann 2016-06-12 22:02:18 UTC 
Created attachment 329651 [details] [review]
Same patch as before, but redone

Better?
Comment 3 Christian Stadelmann 2016-08-13 14:23:00 UTC 
Anything missing to land this trivial patch?
Comment 4 Ernestas Kulik 2016-08-13 19:09:07 UTC 
Review of attachment 329651 [details] [review]:

Apart from the subject line, LGTM. Sorry about the long wait.

For non-source files, we do “<filename>: summary”, unless the patch changes multiple files.

In your case, it would be:
nautilus-window.ui: don't allow main_view to shrink

https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines explains our commit message guidelines.
Comment 5 Carlos Soriano 2016-08-18 22:07:12 UTC 
Hey Christian, thanks a lot for the patch and sorry for the delay.

I agree with Ernestas, it looks good except for those nitpicks :)
Comment 6 Christian Stadelmann 2016-08-29 12:26:05 UTC 
Created attachment 334361 [details] [review]
patch v3

Next try, hope this is correct now.

Note that this patch tends to slightly increase nautilus window minimum width in practice if nautilus has a sidebar and if long file names are present.
Comment 7 Carlos Soriano 2016-08-29 12:45:00 UTC 
Review of attachment 334361 [details] [review]:

LGTM thanks!

Pushed to master.
Comment 8 Christian Stadelmann 2016-09-03 12:48:23 UTC 
Thanks, fix is included in 3.21.91 and newer releases.
Comment 9 Carlos Soriano 2016-09-12 12:43:32 UTC 
*** Bug 771059 has been marked as a duplicate of this bug. ***
Comment 10 Carlos Soriano 2016-09-12 12:45:01 UTC 
Pushed to 3.20 too