GNOME Bugzilla – Bug 767573
Main window: don't shrink main_view to a width of zero
Last modified: 2016-09-12 12:45:01 UTC
Created attachment 329644 [details] [review] A simple 3-line patch by setting "shrink" child property to False Problem: in nautilus' main window, the right side container (GtkOverlay: main_view) can be resized to have a width of 0. This might render nautilus unusable for some users. Steps to reproduce: 1. open nautilus, have a sidebar shown 2. resize sidebar to fill whole window width What happens: main window content (everything in main_view) is hidden. What should happen: main_view should never be hidden. Affected version: nautilus-3.20.1-1.fc24.x86_64 gtk3-3.20.6-1.fc24.x86_64 glib2-2.48.1-1.fc24.x86_64
Hi, Christian, nice catch! For patches you should follow the workflow here: https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Submitting_patches Your patch is not in the format that is easy to apply. Setting the main_view child property “shrink” to “false” causes the sidebar to shrink along with the window, which can get very annoying. It also has the side effect of limiting the minimum size of the window. That’s just my $0.02. Waiting for someone from higher up to provide input.
Created attachment 329651 [details] [review] Same patch as before, but redone Better?
Anything missing to land this trivial patch?
Review of attachment 329651 [details] [review]: Apart from the subject line, LGTM. Sorry about the long wait. For non-source files, we do “<filename>: summary”, unless the patch changes multiple files. In your case, it would be: nautilus-window.ui: don't allow main_view to shrink https://wiki.gnome.org/Newcomers/CodeContributionWorkflow#Commit_guidelines explains our commit message guidelines.
Hey Christian, thanks a lot for the patch and sorry for the delay. I agree with Ernestas, it looks good except for those nitpicks :)
Created attachment 334361 [details] [review] patch v3 Next try, hope this is correct now. Note that this patch tends to slightly increase nautilus window minimum width in practice if nautilus has a sidebar and if long file names are present.
Review of attachment 334361 [details] [review]: LGTM thanks! Pushed to master.
Thanks, fix is included in 3.21.91 and newer releases.
*** Bug 771059 has been marked as a duplicate of this bug. ***
Pushed to 3.20 too