After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767462 - gl: cocoa-videooverlay doesn't work
gl: cocoa-videooverlay doesn't work
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Mac OS
: Normal normal
: 1.12.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-09 16:14 UTC by Philippe Normand
Modified: 2017-07-16 10:35 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gl*:5 log (363.08 KB, text/plain)
2016-06-09 16:14 UTC, Philippe Normand 		  Details
log (45.98 KB, application/x-bzip2)
2016-11-17 20:41 UTC, Philippe Normand 		  Details
proposed patch (1.02 KB, patch)
2017-07-15 16:28 UTC, Philippe Normand 		committed Details | Review

Description Philippe Normand 2016-06-09 16:14:40 UTC 
Created attachment 329484 [details]
gl*:5 log

The window goes below my terminal window and remains gray. Attaching a gl*:5 log.
Comment 1 Matthew Waters (ystreet00) 2016-11-17 04:27:32 UTC 
I can not reproduce here.  Does this occur with latest master?
Comment 2 Philippe Normand 2016-11-17 20:40:49 UTC 
Yes. Attaching a recent log.
Comment 3 Philippe Normand 2016-11-17 20:41:18 UTC 
Created attachment 340184 [details]
log
Comment 4 Matthew Waters (ystreet00) 2016-11-18 00:53:10 UTC 
I cannot not reproduce in cerbero.  Are you running without cerbero?
Comment 5 Philippe Normand 2016-11-18 07:42:34 UTC 
Using gst-uninstalled here, deps installed with Homebrew.
Comment 6 Philippe Normand 2017-07-15 16:19:48 UTC 
Finally found some time to debug this, heh :)

The problem (at least for me) is that gst_gl_window_cocoa_show() is called before gst_gl_window_cocoa_create_window() and that gst_gl_window_cocoa_set_window_handle() is not called after the window was created.

One way to fix it, is to call gst_gl_window_cocoa_set_window_handle() within gst_gl_window_cocoa_create_window(). Would this be acceptable?
Comment 7 Philippe Normand 2017-07-15 16:28:07 UTC 
Created attachment 355691 [details] [review]
proposed patch
Comment 8 Matthew Waters (ystreet00) 2017-07-16 03:02:35 UTC 
Review of attachment 355691 [details] [review]:

This seems fine.
Comment 9 Philippe Normand 2017-07-16 09:31:39 UTC 
Comment on attachment 355691 [details] [review]
proposed patch

commit dcb35318e9d50b153af02822450be89748bb7439 
Author: Philippe Normand <philn@igalia.com>
Date:   Sat Jul 15 17:25:36 2017 +0100

    glwindow_cocoa: fix video overlay support
    
    Make sure the window handle is configured after the NSWindow was created.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767462
Comment 10 Sebastian Dröge (slomo) 2017-07-16 09:45:55 UTC 
This should probably also go into 1.12?
Comment 11 Philippe Normand 2017-07-16 10:33:45 UTC 
Right, I'll push it into the 1.12 branch as well :)