After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767424 - flvdemux: Fix unref assertion failure
flvdemux: Fix unref assertion failure
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-09 00:33 UTC by Seungha Yang
Modified: 2016-06-10 12:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
flvdemux: Fix unref assertion failure (988 bytes, patch)
2016-06-09 00:34 UTC, Seungha Yang
committed Details | Review
Issue file (674.46 KB, video/x-flv)
2016-06-09 23:00 UTC, Seungha Yang
  Details

Description Seungha Yang 2016-06-09 00:33:55 UTC
flvdemux: Fix unref assertion failure

Fix unref assertion failure
Comment 1 Seungha Yang 2016-06-09 00:34:51 UTC
Created attachment 329426 [details] [review]
flvdemux: Fix unref assertion failure
Comment 2 Nicolas Dufresne (ndufresne) 2016-06-09 01:52:55 UTC
How can we reproduce this issue ? Do you have some test we can run ?
Comment 3 Nicolas Dufresne (ndufresne) 2016-06-09 01:54:33 UTC
Review of attachment 329426 [details] [review]:

Looks good.
Comment 4 Nicolas Dufresne (ndufresne) 2016-06-09 02:01:26 UTC
Attachment 329426 [details] pushed as 4e23d20 - flvdemux: Fix unref assertion failure
Comment 5 Nicolas Dufresne (ndufresne) 2016-06-09 02:03:15 UTC
Merged into 1.8 branch as 7eb46b87fe5a31668dcf8ad7247625c4df8acf1a, will make it for 1.8.2.
Comment 6 Seungha Yang 2016-06-09 02:05:24 UTC
(In reply to Nicolas Dufresne (stormer) from comment #2)
> How can we reproduce this issue ? Do you have some test we can run ?

I hope to share the file, but cannot due to security policy... Sorry...
Comment 7 Nicolas Dufresne (ndufresne) 2016-06-09 11:37:46 UTC
(In reply to Seungha Yang from comment #6)
> (In reply to Nicolas Dufresne (stormer) from comment #2)
> > How can we reproduce this issue ? Do you have some test we can run ?
> 
> I hope to share the file, but cannot due to security policy... Sorry...

Maybe you could share the string ? Basically, there is a date in your tags that GStreamer fail to parse. It's not the bug you filed, but it might be a bug.
Comment 8 Seungha Yang 2016-06-09 23:00:02 UTC
Created attachment 329521 [details]
Issue file
Comment 9 Seungha Yang 2016-06-09 23:00:55 UTC
(In reply to Nicolas Dufresne (stormer) from comment #7)
> (In reply to Seungha Yang from comment #6)
> > (In reply to Nicolas Dufresne (stormer) from comment #2)
> > > How can we reproduce this issue ? Do you have some test we can run ?
> > 
> > I hope to share the file, but cannot due to security policy... Sorry...
> 
> Maybe you could share the string ? Basically, there is a date in your tags
> that GStreamer fail to parse. It's not the bug you filed, but it might be a
> bug.

Now I can share the issue file :) Please refer to attached flv.flv file.
Comment 10 Nicolas Dufresne (ndufresne) 2016-06-10 12:04:32 UTC
Great thanks. I extracted the string.

   "Thu May 11 15:57:46 2006 "

Except for the space at the end, it seems all fine, and should be parsable. I'll file a bug. Again, thank you.