After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767218 - [PATCH] Remove a UTF-8 ellipsis from gsignal.h
[PATCH] Remove a UTF-8 ellipsis from gsignal.h
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: gobject
unspecified
Other All
: Normal minor
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-06-03 20:04 UTC by Gerald Combs
Modified: 2016-06-03 20:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Remove a UTF-8 ellipsis. (919 bytes, patch)
2016-06-03 20:04 UTC, Gerald Combs 		committed Details | Review

Description Gerald Combs 2016-06-03 20:04:33 UTC 
Created attachment 329090 [details] [review]
Remove a UTF-8 ellipsis.

Replace a UTF-8 ellipsis with three dots, otherwise Visual C++ will can generate an error depending on your code page:

https://www.wireshark.org/lists/wireshark-dev/201606/msg00009.html

BTW, do the GNOME Programming Guidelines specify the encoding of C sources?
Comment 1 Colin Walters 2016-06-03 20:10:17 UTC 
Review of attachment 329090 [details] [review]:

LGTM, though I'm going to make some minor tweaks to the commit message because my OCD forces me to.
Comment 2 Colin Walters 2016-06-03 20:11:11 UTC 
Tweaked the commit message:
 - Removed period at end of summary
 - Reworked to use a topic prefix
 - Deleted the duplicate first sentence between subject and body
Comment 4 Matthias Clasen 2016-06-03 20:22:37 UTC 
(In reply to Gerald Combs from comment #0)

> BTW, do the GNOME Programming Guidelines specify the encoding of C sources?

Not sure about guidelines, but in the GTK+ stack (glib, pango, gtk+), we're using utf-8 nowadays.