After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767161 - a2dpsink: unref avdtpsink if state transition failed
a2dpsink: unref avdtpsink if state transition failed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-06-02 12:18 UTC by Guillaume Desmottes
Modified: 2016-06-02 23:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
gsta2dpsink: unref avdtpsink if state transition failed (1.06 KB, patch)
2016-06-02 12:18 UTC, Guillaume Desmottes
committed Details | Review

Description Guillaume Desmottes 2016-06-02 12:18:27 UTC
.
Comment 1 Guillaume Desmottes 2016-06-02 12:18:45 UTC
Created attachment 328946 [details] [review]
gsta2dpsink: unref avdtpsink if state transition failed

If for some reason the avdtpsink element can't go READY then the
gsta2dpsink can't either and so should release the ressources it
allocates when trying to do so.

Fix a leak with the generic/states test.
Comment 2 Tim-Philipp Müller 2016-06-02 23:54:55 UTC
Thanks,

commit 007c7f9b7877d028a356258ecb826c61ba2f3fc9
Author: Guillaume Desmottes <guillaume.desmottes@collabora.co.uk>
Date:   Wed May 18 12:48:48 2016 +0300

    a2dpsink: unref avdtpsink if state transition failed
    
    If for some reason the avdtpsink element can't go READY then the
    gsta2dpsink can't either and so should release the ressources it
    allocates when trying to do so.
    
    Fix a leak with the generic/states test.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=767161