After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 767100 - Add an input source type for trackpoints
Add an input source type for trackpoints
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GdkDevice
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Carlos Garnacho
Depends on:
Blocks:
 
 
Reported: 2016-06-01 11:03 UTC by Matthias Clasen
Modified: 2016-10-23 23:59 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add GDK_SOURCE_TRACKPOINT (1.14 KB, patch)
2016-06-01 11:03 UTC, Matthias Clasen
committed Details | Review
Mark trackpoints as GDK_SOURCE_TRACKPOINT (1.00 KB, patch)
2016-06-01 11:04 UTC, Matthias Clasen
committed Details | Review
Remove trackpoint heuristics from gtk (1.02 KB, patch)
2016-06-01 11:04 UTC, Matthias Clasen
committed Details | Review
fix segfault in debug message (1.38 KB, patch)
2016-10-23 23:59 UTC, Peter Hutterer
none Details | Review

Description Matthias Clasen 2016-06-01 11:03:23 UTC
This lets us move the heuristics that currently live in gtkscrolledwindow.c into the GDK backends where they belong.
Comment 1 Matthias Clasen 2016-06-01 11:03:57 UTC
Created attachment 328874 [details] [review]
Add GDK_SOURCE_TRACKPOINT
Comment 2 Matthias Clasen 2016-06-01 11:04:20 UTC
Created attachment 328875 [details] [review]
Mark trackpoints as GDK_SOURCE_TRACKPOINT
Comment 3 Matthias Clasen 2016-06-01 11:04:45 UTC
Created attachment 328876 [details] [review]
Remove trackpoint heuristics from gtk
Comment 4 Carlos Garnacho 2016-06-01 12:12:42 UTC
Comment on attachment 328874 [details] [review]
Add GDK_SOURCE_TRACKPOINT

LGTM
Comment 5 Carlos Garnacho 2016-06-01 12:12:50 UTC
Comment on attachment 328875 [details] [review]
Mark trackpoints as GDK_SOURCE_TRACKPOINT

LGTM. I wonder if it makes sense to mark the "continuous" device in bug #767093 as having this source too.
Comment 6 Carlos Garnacho 2016-06-01 12:12:57 UTC
Comment on attachment 328876 [details] [review]
Remove trackpoint heuristics from gtk

LGTM
Comment 7 Peter Hutterer 2016-10-23 23:59:16 UTC
Created attachment 338311 [details] [review]
fix segfault in debug message

Original patch introduced a segfault when running with --gdk-debug=all. A trackpoint accesses OOM for the source name.