GNOME Bugzilla – Bug 767084
Header cleanup
Last modified: 2016-06-01 19:24:44 UTC
This removes all the "private" header files and moves their content to the header files of the implementations. As far as I can see there is no reason to have any private headers as only pygobject.h gets installed/exported. Imo makes things more structured and readable.
Created attachment 328837 [details] [review] Remove pygi.h and pygi-private.h Instead include things where needed.
Created attachment 328838 [details] [review] Merge pyglib-private.h into pyglib.h No need for another header
Created attachment 328839 [details] [review] Remove pygobject-private.h and rename pygobject.c to pygobject-object.c Move all the random declarations in pygobject-private.h to their respective header files. Rename pygobject.c to pygobject-object.c so it's clearer that it's not the implementation of pygobject.h. Add a new pygobject-internal.h which includes pygobject.h with _INSIDE_PYGOBJECT_ defined like pygobject-private.h did.
Created attachment 328840 [details] [review] Remove pygobject-external.h It's not used any more
Review of attachment 328837 [details] [review]: Sure.
Review of attachment 328838 [details] [review]: LGTM
Review of attachment 328839 [details] [review]: I think there is probably a lot useful history stored in pygobject.c. Can you add comments/notes along with example git commands to the commit message to help people with historical analysis/blaming? Something like: To find old history, use: git blame <this-sha>^ -- pygobject.c
Review of attachment 328840 [details] [review]: Nice work, thanks for all the cleanup!
(In reply to Simon Feltman from comment #7) > Review of attachment 328839 [details] [review] [review]: > > I think there is probably a lot useful history stored in pygobject.c. Can > you add comments/notes along with example git commands to the commit message > to help people with historical analysis/blaming? Something like: > > To find old history, use: > git blame <this-sha>^ -- pygobject.c git blame should work as before (it even contains data form the last two renames of that file) The only things that might be useful is a note that "git log --follow pygobject-object.c" follows renames and for the gnome git web interface that "https://git.gnome.org/browse/pygobject/log/gi/pygobject.c?id=6b702c052e9f26e809cff494f0c896d17a514c64" will show the log of the previous file. Should I include those two? Or anything else? ----- Thanks for the quick reviews!
Created attachment 328856 [details] [review] Remove pygobject-private.h and rename pygobject.c to pygobject-object.c Move all the random declarations in pygobject-private.h to their respective header files. Rename pygobject.c to pygobject-object.c so it's clearer that it's not the implementation of pygobject.h. Add a new pygobject-internal.h which includes pygobject.h with _INSIDE_PYGOBJECT_ defined like pygobject-private.h did. In case you are looking at the git log and end up here due to the rename try: git log --follow pygobject-object.c or on the web interface go to the history of the old file name: https://git.gnome.org/browse/pygobject/log/gi/pygobject.c?id=6b702c052e9f26e809cff494f0c896d17a514c64
Review of attachment 328856 [details] [review]: Ok, thanks for the update.