After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766800 - videodecoder: Make sure the DISCONT flag is set on the outgoing buffer
videodecoder: Make sure the DISCONT flag is set on the outgoing buffer
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-23 13:38 UTC by Edward Hervey
Modified: 2016-06-02 08:25 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videodecoder: Make sure the DISCONT flag is set on the outgoing buffer (1.52 KB, patch)
2016-05-23 13:38 UTC, Edward Hervey 		reviewed Details | Review

Description Edward Hervey 2016-05-23 13:38:13 UTC 
See commit
Comment 1 Edward Hervey 2016-05-23 13:38:17 UTC 
Created attachment 328391 [details] [review]
videodecoder: Make sure the DISCONT flag is set on the outgoing buffer

The base class was setting the DISCONT flag before checking whether the buffer
would be in segment or not.

Fix issues with DISCONT flags not being properly propagated downstream when
decoders buffers were out of segment.
Comment 2 Sebastian Dröge (slomo) 2016-05-25 12:28:45 UTC 
Review of attachment 328391 [details] [review]:

audiodecoder already does the right thing?

::: gst-libs/gst/video/gstvideodecoder.c
@@ +3072,2 @@
   if (priv->discont) {
     GST_BUFFER_FLAG_SET (output_buffer, GST_BUFFER_FLAG_DISCONT);

Can this go away too then? You would set the flag again further down anyway?
Comment 3 Sebastian Dröge (slomo) 2016-06-02 08:24:07 UTC 
I accidentially pushed this now, but the patch itself seems fine. Should just check the same for audiodecoder, which I'll do now shortly.
Comment 4 Sebastian Dröge (slomo) 2016-06-02 08:25:04 UTC 
It does