After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766750 - No wayland support at all
No wayland support at all
Status: RESOLVED FIXED
Product: sushi
Classification: Core
Component: general
3.20.x
Other All
: Normal critical
: ---
Assigned To: Sushi maintainer(s)
Sushi maintainer(s)
Depends on:
Blocks: WaylandRelated
 
 
Reported: 2016-05-21 12:08 UTC by Christian Stadelmann
Modified: 2016-08-31 16:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Make sushi work under Wayland (988 bytes, patch)
2016-08-25 19:47 UTC, Matthias Clasen
committed Details | Review

Description Christian Stadelmann 2016-05-21 12:08:02 UTC
Every time I start a sushi process and display a window for the first time, I'm getting this traceback:

(sushi-start:7101): Gjs-WARNING **: JS ERROR: Exception in method call: ShowFile: TypeError: this._gtkWindow.get_window(...).move_to_current_desktop is not a function
MainWindow<.setParent@/usr/share/sushi/js/ui/mainWindow.js:547
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
Application<.ShowFile@/usr/share/sushi/js/ui/application.js:102
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
_handleMethodCall@resource:///org/gnome/gjs/modules/overrides/Gio.js:261
_wrapJSObject/<@resource:///org/gnome/gjs/modules/overrides/Gio.js:331
run@/usr/share/sushi/js/ui/main.js:51
@main.c:2

Each time sushi shows a window for previewing a file I'm getting this traceback:

(sushi-start:7101): Gjs-WARNING **: JS ERROR: TypeError: this._renderer is null
MainWindow<._clearAndQuit@/usr/share/sushi/js/ui/mainWindow.js:531
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
MainWindow<._onKeyPressEvent@/usr/share/sushi/js/ui/mainWindow.js:167
wrapper@resource:///org/gnome/gjs/modules/lang.js:178
run@/usr/share/sushi/js/ui/main.js:51
@main.c:2

The window is always empty.

This issue may or may not be related to bug #712618.

I'm running sushi-3.20.0-1.fc24.x86_64 on a gnome+wayland session with gtk3-3.20.4-1.fc24.x86_64.
Comment 1 Simon McVittie 2016-05-25 10:40:26 UTC
Workaround: patch /usr/bin/sushi (or wherever it's installed) to add "export GDK_BACKEND=x11", forcing it to use X11 even though the rest of your desktop is Wayland.
Comment 2 Matthias Clasen 2016-08-25 19:47:01 UTC
Created attachment 334173 [details] [review]
Make sushi work under Wayland

move_to_current_desktop is x11 backend api. We can't call it
unconditionally.
Comment 3 Cosimo Cecchi 2016-08-25 20:19:17 UTC
Review of attachment 334173 [details] [review]:

Sure, looks good.
Comment 4 Matthias Clasen 2016-08-31 16:07:34 UTC
Attachment 334173 [details] pushed as 0e3a847 - Make sushi work under Wayland