After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766555 - souhttpsrc: Handle redirects to non-HTTP URLs
souhttpsrc: Handle redirects to non-HTTP URLs
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-17 09:40 UTC by Carlos Rafael Giani
Modified: 2018-11-03 15:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
First attempt at redirecting non-HTTP URLs (3.01 KB, patch)
2016-05-17 09:42 UTC, Carlos Rafael Giani 		reviewed Details | Review

Description Carlos Rafael Giani 2016-05-17 09:40:13 UTC 
Sometimes, HTTP URLs might respond with 302/303 redirect to a non-HTTP URL. Some radio stations do this to redirect to mms:// URLs for example. In such cases, souphttpsrc does not redirect properly. Add code to post a redirect message in case of non-HTTP URLs.
Comment 1 Carlos Rafael Giani 2016-05-17 09:42:28 UTC 
Created attachment 328051 [details] [review]
First attempt at redirecting non-HTTP URLs

This is a first attempt at solving this. It works, but still uses the element-based redirect message style that is currently used by uridecodebin. Once https://bugzilla.gnome.org/show_bug.cgi?id=631673 is committed, the patch will be updated to post that message instead.
Comment 2 Sebastian Dröge (slomo) 2016-05-17 10:12:47 UTC 
Review of attachment 328051 [details] [review]:

Makes sense

::: ext/soup/gstsouphttpsrc.c
@@ +1127,3 @@
+
+    for (protocol = protocols; *protocol != NULL; ++protocol) {
+      if (g_str_has_prefix (redirection_uri, *protocol)) {

Here now "http" would match on "https://blabla"... or "icy" on "icyblablabla://". I think this should be a bit more exact
Comment 3 GStreamer system administrator 2018-11-03 15:09:19 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-good/issues/274.