GNOME Bugzilla – Bug 766513
Introduce the new Search Locations dialog
Last modified: 2016-05-30 13:29:19 UTC
Considering the new mockups at https://wiki.gnome.org/Design/SystemSettings/Search
Created attachment 327977 [details] [review] search: introduce the new Search Locations dialog https://wiki.gnome.org/Design/SystemSettings/Search
Created attachment 327979 [details] screencast
Review of attachment 327977 [details] [review]: You seem to have lost the sorting, is that expected? ::: panels/search/cc-search-locations-dialog.c @@ +614,2 @@ gtk_widget_show (list_box); + /* FIXME: do not query for places everytime */ Want to fix that before pushing?
(In reply to Bastien Nocera from comment #3) > Review of attachment 327977 [details] [review] [review]: > > You seem to have lost the sorting, is that expected? Yes, I guess we don't want that for the XDG locations. What do you think? > > ::: panels/search/cc-search-locations-dialog.c > @@ +614,2 @@ > gtk_widget_show (list_box); > + /* FIXME: do not query for places everytime */ > > Want to fix that before pushing? I will do it.
Created attachment 328639 [details] [review] search: introduce the new Search Locations dialog https://wiki.gnome.org/Design/SystemSettings/Search
(In reply to Felipe Borges from comment #4) > (In reply to Bastien Nocera from comment #3) > > Review of attachment 327977 [details] [review] [review] [review]: > > > > You seem to have lost the sorting, is that expected? > > Yes, I guess we don't want that for the XDG locations. What do you think? Not sure. Is that sorted in the nautilus/file-chooser sidebars? We'd want to do the same. Is that what you implemented?
(In reply to Bastien Nocera from comment #6) > (In reply to Felipe Borges from comment #4) > > (In reply to Bastien Nocera from comment #3) > > > Review of attachment 327977 [details] [review] [review] [review] [review]: > > > > > > You seem to have lost the sorting, is that expected? > > > > Yes, I guess we don't want that for the XDG locations. What do you think? > > Not sure. Is that sorted in the nautilus/file-chooser sidebars? We'd want to > do the same. Is that what you implemented? Yes, I forgot to mention that. Nautilus doesn't sort them (it appends new items), but it allows the user to reorder the rows by drag & drop.
Review of attachment 328639 [details] [review]: I still don't see the sorting, did you upload an older version? ::: panels/search/cc-search-locations-dialog.c @@ +619,3 @@ + places = get_places_list (); + + list_box = GTK_WIDGET (gtk_builder_get_object (dialog_builder, "places-list")); Do you want to use templates instead? @@ +634,2 @@ widget = GTK_WIDGET (gtk_builder_get_object (dialog_builder, "locations_add")); + Whitespace change.
Created attachment 328725 [details] [review] search: introduce the new Search Locations dialog https://wiki.gnome.org/Design/SystemSettings/Search
Review of attachment 328725 [details] [review]: Looks good otherwise. ::: panels/search/cc-search-locations-dialog.c @@ +560,2 @@ place->cancellable = g_cancellable_new (); + g_file_query_info_async (place->location, "standard::display-name", G_FILE_ATTRIBUTE_STANDARD_DISPLAY_NAME @@ +575,2 @@ places = get_places_list (); + Whitespace change. Try adding: [color] ui = auto to your ~/.gitconfig, which will show those trailing whitespaces.
(In reply to Bastien Nocera from comment #10) > Review of attachment 328725 [details] [review] [review]: > > @@ +575,2 @@ > places = get_places_list (); > + > > Whitespace change. Try adding: > [color] > ui = auto > to your ~/.gitconfig, which will show those trailing whitespaces. Thanks for the tip. Attachment 328725 [details] pushed as f473ec4 - search: introduce the new Search Locations dialog