After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766477 - videoscale: ignores possible passthrough in fixate_caps
videoscale: ignores possible passthrough in fixate_caps
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-15 13:55 UTC by Matthew Waters (ystreet00)
Modified: 2018-11-03 11:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
videoscale: check intersection before truncating on fixate_caps (1.54 KB, patch)
2016-05-15 15:41 UTC, Matthew Waters (ystreet00) 		none Details | Review

Description Matthew Waters (ystreet00) 2016-05-15 13:55:45 UTC 
While implementing bug 756935, I noticed that videoscale ignores the unfixed width/height and ends up scaling itself rather than in the sink.

If upstream has fixed caps (e.g. from a video file) and a preferred width/height in the first structure and unfixed width/height in subsequent structure/s, then videoscale is truncating before attempting to fixate which will lose the unfixed caps.
Comment 1 Matthew Waters (ystreet00) 2016-05-15 15:41:54 UTC 
Created attachment 327938 [details] [review]
videoscale: check intersection before truncating on fixate_caps

This is a patch that fixes the issue but likely breaks other use cases.
Comment 2 Matthew Waters (ystreet00) 2016-05-15 16:06:41 UTC 
One such example that this breaks is that videotestsrc ! video/x-raw,width=320,height=240 ! videoscale ! ximagesink.

videoscale is now passthrough and ximagesink cannot scale the image so places it in the centre of the output.

One option is to make ximagesink only expose the currently configure output size so that videoscale will scale however that will cause some more negotiation errors with ximagesink.
Comment 3 GStreamer system administrator 2018-11-03 11:46:29 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/268.