After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766467 - oggdemux: Reset keyframe_granule when needed
oggdemux: Reset keyframe_granule when needed
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
unspecified
Other All
: Normal normal
: 1.9.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-15 10:04 UTC by Edward Hervey
Modified: 2016-05-15 12:40 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
oggdemux: Reset keyframe_granule when needed (869 bytes, patch)
2016-05-15 10:04 UTC, Edward Hervey 		none Details | Review

Description Edward Hervey 2016-05-15 10:04:43 UTC 
Without this, we would end up with a bogus granule value just after a seek,
which would result in *not* pushing out the keyframe (it would be dropped
because it has an invalid granulepos).

We would push everything else until the next keyframe, resulting in the
decoder dropping everything, resulting in multiqueue filling up, resulting
in pipelines hanging.
Comment 1 Edward Hervey 2016-05-15 10:04:59 UTC 
Created attachment 327925 [details] [review]
oggdemux: Reset keyframe_granule when needed

This avoids ending up with bogus values when doing flushing seeks
in push-mode.