After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766450 - video-track: don't leak restriction caps in _sync_capsfilter_with_track
video-track: don't leak restriction caps in _sync_capsfilter_with_track
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-14 17:53 UTC by Aurélien Zanelli
Modified: 2016-07-04 10:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
video-track: don't leak restriction caps in _sync_capsfilter_with_track (1.54 KB, patch)
2016-05-14 17:54 UTC, Aurélien Zanelli
committed Details | Review

Description Aurélien Zanelli 2016-05-14 17:53:16 UTC
When syncing video-track capsfilter, we get current set restriction caps with g_object_get but we never unref it, causing a leak.
Comment 1 Aurélien Zanelli 2016-05-14 17:54:15 UTC
Created attachment 327894 [details] [review]
video-track: don't leak restriction caps in _sync_capsfilter_with_track
Comment 2 Tim-Philipp Müller 2016-06-20 11:35:20 UTC
Thanks, pushed:


commit 7529e25b49f70c93b55adc6cc2c4548a3231d367
Author: Aurélien Zanelli <aurelien.zanelli@darkosphere.fr>
Date:   Sat May 14 19:02:57 2016 +0200

    video-track: don't leak restriction caps in _sync_capsfilter_with_track()
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766450
Comment 3 Sebastian Dröge (slomo) 2016-06-27 06:31:02 UTC
Should this go into 1.8?