After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766449 - ges: fix various leaks with usage of ges_timeline_element_lookup_child
ges: fix various leaks with usage of ges_timeline_element_lookup_child
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-editing-services
git master
Other Linux
: Normal normal
: 1.8.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-14 17:44 UTC by Aurélien Zanelli
Modified: 2016-07-04 10:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
ges: fix various leaks with usage of ges_timeline_element_lookup_child (2.61 KB, patch)
2016-05-14 17:45 UTC, Aurélien Zanelli 		committed Details | Review

Description Aurélien Zanelli 2016-05-14 17:44:21 UTC 
Some internal caller of ges_timeline_element_lookup_child forgot to unref out values causing some leaks.
Comment 1 Aurélien Zanelli 2016-05-14 17:45:17 UTC 
Created attachment 327893 [details] [review]
ges: fix various leaks with usage of ges_timeline_element_lookup_child
Comment 2 Aurélien Zanelli 2016-05-14 23:50:25 UTC 
(In reply to Aurélien Zanelli from comment #1)
> Created attachment 327893 [details] [review] [review]
> ges: fix various leaks with usage of ges_timeline_element_lookup_child

I found that this patch causes or reveals an issue when disposing of GstFramePositioner with video track. I will try to look at it tomorrow, if no one is quicker than me :)
Comment 3 Tim-Philipp Müller 2016-06-20 11:43:20 UTC 
Aurélien: any updates?
Comment 4 Tim-Philipp Müller 2016-06-20 11:43:39 UTC 
Comment on attachment 327893 [details] [review]
ges: fix various leaks with usage of ges_timeline_element_lookup_child

as per comment.
Comment 5 Aurélien Zanelli 2016-06-20 12:06:48 UTC 
I forgot to update this report. The issue revealed by this patch was bug 766525 which is now fixed. So we could review this patch and commit it if it's good.
Comment 6 Tim-Philipp Müller 2016-06-20 12:27:06 UTC 
Thanks, pushed:

commit 96a8c6db0ca5b1d74575da914c3d11fcccb8469a
Author: Aurélien Zanelli <aurelien.zanelli@darkosphere.fr>
Date:   Sat May 14 19:33:05 2016 +0200

    ges: fix various leaks with usage of ges_timeline_element_lookup_child
    
    Some callers forgot to unref out child, pspec or both leading to leaks.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=766449


(looks all fine to me)
Comment 7 Sebastian Dröge (slomo) 2016-06-27 06:31:08 UTC 
Should this go into 1.8?