After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766407 - Some build-related defects in glib testsuite
Some build-related defects in glib testsuite
Status: RESOLVED FIXED
Product: glib
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2016-05-14 04:59 UTC by LRN
Modified: 2016-05-15 00:10 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
testsuite: include pthread.h in thread testfile (745 bytes, patch)
2016-05-14 04:59 UTC, LRN 		committed Details | Review
testsuite: don't forget -DPCRE_STATIC when PCRE is static (840 bytes, patch)
2016-05-14 04:59 UTC, LRN 		committed Details | Review
testsuite: override check-TESTS target in gio tests subdir (1.11 KB, patch)
2016-05-14 04:59 UTC, LRN 		committed Details | Review

Description LRN 2016-05-14 04:59:33 UTC 
* a threading test fails to build due to a lack of prototype for a pthread function
* a pcre test fails to build, because it can't property link to internal pcre due to missing cflag
* make check TESTS=... fails in gio due to weird interaction between TESTS and SUBDIRS
Comment 1 LRN 2016-05-14 04:59:43 UTC 
Created attachment 327846 [details] [review]
testsuite: include pthread.h in thread testfile
Comment 2 LRN 2016-05-14 04:59:49 UTC 
Created attachment 327847 [details] [review]
testsuite: don't forget -DPCRE_STATIC when PCRE is static
Comment 3 LRN 2016-05-14 04:59:55 UTC 
Created attachment 327848 [details] [review]
testsuite: override check-TESTS target in gio tests subdir

This prevents testsuite from trying to build any TESTS in that
subdirectory, which will fail, because there are no TESTS defined
in that Makefile.am.

This happens when user runs make check TESTS=...
Comment 4 Colin Walters 2016-05-14 11:52:54 UTC 
Review of attachment 327846 [details] [review]:

Ok - with patches like this it'd be useful to say something like:

"Fixes the build on FreeBSD X" or whatever.
Comment 5 Colin Walters 2016-05-14 11:53:19 UTC 
Review of attachment 327847 [details] [review]:

OK.
Comment 6 Colin Walters 2016-05-14 11:59:16 UTC 
Review of attachment 327848 [details] [review]:

This seems like an automake bug or something...it shouldn't propagate the TESTS= variable when recursing or something?

But anyways, it does indeed make `TESTS=` work, so OK.
Comment 7 LRN 2016-05-15 00:10:10 UTC 
Attachment 327846 [details] pushed as 36c47f2 - testsuite: include pthread.h in thread testfile
Attachment 327847 [details] pushed as e88796c - testsuite: don't forget -DPCRE_STATIC when PCRE is static
Attachment 327848 [details] pushed as 2aa7338 - testsuite: override check-TESTS target in gio tests subdir