After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 766314 - Spurious leave-notify event after touch up
Spurious leave-notify event after touch up
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Wayland
3.16.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2016-05-12 10:40 UTC by Sjoerd Simons
Modified: 2016-05-18 10:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Proposed patch (2.35 KB, patch)
2016-05-12 10:40 UTC, Sjoerd Simons 		none Details | Review
wayland: Avoid spurious crossing events from master touch device (3.89 KB, patch)
2016-05-12 12:01 UTC, Carlos Garnacho 		committed Details | Review

Description Sjoerd Simons 2016-05-12 10:40:46 UTC 
Created attachment 327689 [details] [review]
Proposed patch

On a touchscreen device after touch end both a leave-notify event iwth mode _TOUCH_END and one with mode _NORMAL occurred. Only the first one should happen.
Comment 1 Carlos Garnacho 2016-05-12 12:01:57 UTC 
Created attachment 327697 [details] [review]
wayland: Avoid spurious crossing events from master touch device

Only generate crossing events on wl_touch.down for the virtual master
device used for touch events, and only whenever this virtual device
actually moves across surfaces. This behavior resembles better what is
expected in X11, where the pointer is warped to the touch position
on XITouchBegin.

This avoids the double emission of leave events when the pointer
emulating touch is lifted, that crossing event will be instead
generated when/if the focus surface changes.
Comment 2 Sjoerd Simons 2016-05-16 11:57:11 UTC 
Review of attachment 327697 [details] [review]:

Looks good to me
Comment 3 Matthias Clasen 2016-05-18 03:02:02 UTC 
Review of attachment 327697 [details] [review]:

make sense
Comment 4 Carlos Garnacho 2016-05-18 10:56:16 UTC 
Attachment 327697 [details] pushed as 783c302 - wayland: Avoid spurious crossing events from master touch device