After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765953 - test_parse failed when building orc-0.4.25 on armv7hl
test_parse failed when building orc-0.4.25 on armv7hl
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: orc
unspecified
Other Linux
: Normal normal
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-03 23:59 UTC by Pascal Terjan
Modified: 2016-05-04 11:18 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to not fail test_parse when using emulation (1.20 KB, patch)
2016-05-04 09:41 UTC, Pascal Terjan
committed Details | Review

Description Pascal Terjan 2016-05-03 23:59:05 UTC
$ cat testsuite/test-suite.log
==========================================
   orc 0.4.25: testsuite/test-suite.log
==========================================

# TOTAL: 10
# PASS:  9
# SKIP:  0
# XFAIL: 0
# FAIL:  1
# XPASS: 0
# ERROR: 0

.. contents:: :depth: 2

FAIL: test_parse
================

compile error: 256
FAIL test_parse (exit status: 1)


The test tests that a program compile both with "\n" and "\r\n" line endings, but it actually fails in both cases.
Comment 1 Pascal Terjan 2016-05-04 00:12:27 UTC
Would it make sense to test ORC_COMPILE_RESULT_IS_FATAL() instead of comparing with ORC_COMPILE_RESULT_OK?
Comment 2 Sebastian Dröge (slomo) 2016-05-04 07:01:23 UTC
Why does it fail in your case? Can you check with ORC_DEBUG=5?

What you suggest makes sense though
Comment 3 Pascal Terjan 2016-05-04 08:59:56 UTC
ORC: INFO: orcdebug.c(70): _orc_debug_init(): orc-0.4.25 debug init
ORC: INFO: orccpu-arm.c(89): orc_check_neon_proc_auxv(): arm hwcap 0000a0d7
ORC: INFO: orccpu-arm.c(91): orc_check_neon_proc_auxv(): arm platform v7l
ORC: INFO: orcprogram-neon.c(129): orc_neon_init(): marking neon backend non-executable
ORC: DEBUG: orctest.c(573): orc_test_compare_output_full(): got here
ORC: INFO: orccompiler.c(194): orc_program_compile_full(): initializing compiler for program "orc_add_s16"
ORC: LOG: orccompiler.c(226): orc_program_compile_full(): variables
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 0: d1 size 2 type 2 alloc 0
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 4: s1 size 2 type 1 alloc 0
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 5: s2 size 2 type 1 alloc 0
ORC: LOG: orccompiler.c(236): orc_program_compile_full(): instructions
ORC: LOG: orccompiler.c(243): orc_program_compile_full(): 0: addw 0 0 4 5
ORC: WARNING: orccompiler.c(392): orc_program_compile_full(): program orc_add_s16 failed to compile, reason: Compilation disabled, using emulation
ORC: INFO: orccompiler.c(415): orc_program_compile_full(): finished compiling (fail)
ORC: INFO: orccompiler.c(194): orc_program_compile_full(): initializing compiler for program "orc_add_s16"
ORC: LOG: orccompiler.c(226): orc_program_compile_full(): variables
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 0: d1 size 2 type 2 alloc 0
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 4: s1 size 2 type 1 alloc 0
ORC: LOG: orccompiler.c(233): orc_program_compile_full(): 5: s2 size 2 type 1 alloc 0
ORC: LOG: orccompiler.c(236): orc_program_compile_full(): instructions
ORC: LOG: orccompiler.c(243): orc_program_compile_full(): 0: addw 0 0 4 5
ORC: WARNING: orccompiler.c(392): orc_program_compile_full(): program orc_add_s16 failed to compile, reason: Compilation disabled, using emulation
ORC: INFO: orccompiler.c(415): orc_program_compile_full(): finished compiling (fail)
compile error: 256
FAIL test_parse (exit status: 1)
Comment 4 Sebastian Dröge (slomo) 2016-05-04 09:03:40 UTC
Makes sense. Do you want to provide a patch?
Comment 5 Pascal Terjan 2016-05-04 09:26:23 UTC
Sure, will do that today.
Comment 6 Pascal Terjan 2016-05-04 09:41:31 UTC
Created attachment 327277 [details] [review]
Patch to not fail test_parse when using emulation
Comment 7 Pascal Terjan 2016-05-04 10:42:29 UTC
(I don't have commit rights)
Comment 8 Tim-Philipp Müller 2016-05-04 11:17:33 UTC
We just mark it accepted_commitnow so we don't forget and can then push it all later.

Thanks for the patch!

commit c471352db4764bdcc24223338639e4c3f52b3e51
Author: Pascal Terjan <pterjan@google.com>
Date:   Wed May 4 09:36:21 2016 +0000

    Fix test_parse with no executable backend
    
    https://bugzilla.gnome.org/show_bug.cgi?id=765953