After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765909 - Couple of small input chooser usability improvements
Couple of small input chooser usability improvements
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Region & Language
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-05-02 16:22 UTC by Rui Matos
Modified: 2016-05-13 17:01 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
region: Handle escape in the input chooser's filter entry (1.45 KB, patch)
2016-05-02 16:22 UTC, Rui Matos 		committed Details | Review
region: Be more thorough in cc_input_chooser_reset() (1.06 KB, patch)
2016-05-02 16:22 UTC, Rui Matos 		committed Details | Review

Description Rui Matos 2016-05-02 16:22:19 UTC 
Done for a downstream request
Comment 1 Rui Matos 2016-05-02 16:22:25 UTC 
Created attachment 327160 [details] [review]
region: Handle escape in the input chooser's filter entry

Reset the chooser on escape.
Comment 2 Rui Matos 2016-05-02 16:22:31 UTC 
Created attachment 327161 [details] [review]
region: Be more thorough in cc_input_chooser_reset()

This should result in returning to the initial state as intended
instead of keeping the filter entry shown and the filter applied.
Comment 3 Bastien Nocera 2016-05-04 08:54:56 UTC 
Review of attachment 327160 [details] [review]:

Sure.
Comment 4 Bastien Nocera 2016-05-04 08:56:03 UTC 
Review of attachment 327161 [details] [review]:

::: panels/region/cc-input-chooser.c
@@ +1152,3 @@
 cc_input_chooser_reset (GtkWidget *chooser)
 {
+  CcInputChooserPrivate *priv = GET_PRIVATE (chooser);

A few line of spacing wouldn't hurt.
Comment 5 Rui Matos 2016-05-13 17:00:59 UTC 
Attachment 327160 [details] pushed as ff65674 - region: Handle escape in the input chooser's filter entry
Attachment 327161 [details] pushed as 2e45eea - region: Be more thorough in cc_input_chooser_reset()