After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 765806 - qtdemux: Store the segment sequence number in the EOS events and STREAM_DONE events/message
qtdemux: Store the segment sequence number in the EOS events and STREAM_DONE ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
unspecified
Other All
: Normal normal
: 1.8.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2016-04-29 12:06 UTC by Sebastian Dröge (slomo)
Modified: 2016-05-02 07:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
qtdemux: Store the segment sequence number in the EOS events and STREAM_DONE events/message (7.20 KB, patch)
2016-04-29 12:06 UTC, Sebastian Dröge (slomo) 		none Details | Review
qtdemux: Store the segment sequence number in the EOS events and SEGMENT_DONE events/message (7.20 KB, patch)
2016-04-29 12:13 UTC, Sebastian Dröge (slomo) 		committed Details | Review

Description Sebastian Dröge (slomo) 2016-04-29 12:06:12 UTC 
See commit message. Without this, GES for example will never consider the EOS
at the seek stop position to be for this segment... and just wait forever
instead of considering the segment done.
Comment 1 Sebastian Dröge (slomo) 2016-04-29 12:06:16 UTC 
Created attachment 327013 [details] [review]
qtdemux: Store the segment sequence number in the EOS events and STREAM_DONE events/message

Also instead of storing it per stream, store it globally in the demuxer. It's
the same for each stream anyway.
Comment 2 Sebastian Dröge (slomo) 2016-04-29 12:13:54 UTC 
Created attachment 327014 [details] [review]
qtdemux: Store the segment sequence number in the EOS events and SEGMENT_DONE events/message

Also instead of storing it per stream, store it globally in the demuxer. It's
the same for each stream anyway.
Comment 3 Sebastian Dröge (slomo) 2016-04-29 12:27:54 UTC 
Attachment 327014 [details] pushed as e0b2605 - qtdemux: Store the segment sequence number in the EOS events and SEGMENT_DONE events/message